All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <dahi@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org, gleb@kernel.org, jfrei@linux.vnet.ibm.com,
	borntraeger@de.ibm.com, cornelia.huck@de.ibm.com
Subject: Re: [PATCH RFC 0/2] assign each vcpu an owning thread and improve yielding
Date: Wed, 03 Dec 2014 13:54:03 +0100	[thread overview]
Message-ID: <547F07EB.4080807@redhat.com> (raw)
In-Reply-To: <20141203131215.695a3ab7@thinkpad-w530>



On 03/12/2014 13:12, David Hildenbrand wrote:
>> This series improves yielding on architectures that cannot disable preemption
>> while entering the guest and makes the creating thread of a VCPU the owning
>> thread and therefore the yield target when yielding to that VCPU.
>>
>> We should focus on the case creating thread == executing thread and therefore
>> remove the complicated handling of PIDs involving synchronize_rcus.
>>
>> This way we can speed up the creation of VCPUs and directly yield to the
>> executing vcpu threads.
>>
>> Please note that - in theory - all VCPU ioctls should be triggered from the same
>> VCPU thread, so changing threads is not a scenario we should optimize.
>>
>>
>> David Hildenbrand (2):
>>   KVM: don't check for PF_VCPU when yielding
>>   KVM: thread creating a vcpu is the owner of that vcpu
>>
>>  include/linux/kvm_host.h |  1 +
>>  virt/kvm/kvm_main.c      | 22 ++--------------------
>>  2 files changed, 3 insertions(+), 20 deletions(-)
>>
> 
> Hi Paolo,
> 
> would be good if you could have a look at these patches.

Sure.

I think patch 1 is fine and I am applying it.  For patch 2, what about
moving the ->pid assignment in the KVM_RUN case of kvm_vcpu_ioctl?

Paolo

  reply	other threads:[~2014-12-03 12:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 16:04 [PATCH RFC 0/2] assign each vcpu an owning thread and improve yielding David Hildenbrand
2014-11-25 16:04 ` [PATCH RFC 1/2] KVM: don't check for PF_VCPU when yielding David Hildenbrand
2014-11-26  7:51   ` Christian Borntraeger
2014-11-26  9:23     ` David Hildenbrand
2014-11-26  9:31       ` Christian Borntraeger
2014-11-28 10:08         ` Raghavendra KT
2014-11-28 10:58           ` Christian Borntraeger
2014-11-28 11:40             ` Raghavendra K T
2014-12-01  9:54               ` David Hildenbrand
2014-12-03 12:53               ` Paolo Bonzini
2014-12-03 13:02   ` Paolo Bonzini
2014-12-03 13:04     ` David Hildenbrand
2014-11-25 16:04 ` [PATCH RFC 2/2] KVM: thread creating a vcpu is the owner of that vcpu David Hildenbrand
2014-11-26  7:54   ` Christian Borntraeger
2014-12-03 12:53   ` Paolo Bonzini
2014-12-03 12:12 ` [PATCH RFC 0/2] assign each vcpu an owning thread and improve yielding David Hildenbrand
2014-12-03 12:54   ` Paolo Bonzini [this message]
2014-12-03 13:00     ` David Hildenbrand
2014-12-03 13:00     ` Christian Borntraeger
2014-12-03 13:06       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547F07EB.4080807@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=gleb@kernel.org \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.