From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [patch net-next 6/6] net_sched: cls_cgroup: remove unnecessary if
Date: Wed, 03 Dec 2014 08:07:06 -0500 [thread overview]
Message-ID: <547F0AFA.7090001@mojatatu.com> (raw)
In-Reply-To: <1417539636-12710-7-git-send-email-jiri@resnulli.us>
On 12/02/14 12:00, Jiri Pirko wrote:
> since head->handle == handle (checked before), just assign handle.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
> net/sched/cls_cgroup.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c
> index d61a801..dbee65e 100644
> --- a/net/sched/cls_cgroup.c
> +++ b/net/sched/cls_cgroup.c
> @@ -117,11 +117,7 @@ static int cls_cgroup_change(struct net *net, struct sk_buff *in_skb,
> return -ENOBUFS;
>
> tcf_exts_init(&new->exts, TCA_CGROUP_ACT, TCA_CGROUP_POLICE);
> - if (head)
> - new->handle = head->handle;
> - else
> - new->handle = handle;
> -
> + new->handle = handle;
Hrm. head could be NULL, no?
cheers,
jamal
next prev parent reply other threads:[~2014-12-03 13:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 17:00 [patch net-next 0/6] net_sched: cls_*: couple of fixes Jiri Pirko
2014-12-02 17:00 ` [patch net-next 1/6] net_sched: cls_basic: remove unnecessary iteration and use passed arg Jiri Pirko
2014-12-03 12:45 ` Jamal Hadi Salim
2014-12-02 17:00 ` [patch net-next 2/6] net_sched: cls_bpf: " Jiri Pirko
2014-12-03 12:46 ` Jamal Hadi Salim
2014-12-03 13:38 ` Daniel Borkmann
2014-12-02 17:00 ` [patch net-next 3/6] net_sched: cls_bpf: remove faulty use of list_for_each_entry_rcu Jiri Pirko
2014-12-03 12:19 ` Pablo Neira Ayuso
2014-12-03 13:21 ` Jiri Pirko
2014-12-03 13:50 ` Pablo Neira Ayuso
2014-12-03 12:51 ` Jamal Hadi Salim
2014-12-03 13:26 ` Jiri Pirko
2014-12-03 14:37 ` Jamal Hadi Salim
2014-12-03 15:20 ` Jiri Pirko
2014-12-03 21:15 ` Jamal Hadi Salim
2014-12-03 23:15 ` Daniel Borkmann
2014-12-02 17:00 ` [patch net-next 4/6] net_sched: cls_flow: " Jiri Pirko
2014-12-03 13:02 ` Jamal Hadi Salim
2014-12-02 17:00 ` [patch net-next 5/6] net_sched: cls_flow: remove duplicate assignments Jiri Pirko
2014-12-02 17:00 ` [patch net-next 6/6] net_sched: cls_cgroup: remove unnecessary if Jiri Pirko
2014-12-03 13:07 ` Jamal Hadi Salim [this message]
2014-12-03 13:18 ` Jiri Pirko
2014-12-03 14:30 ` Jamal Hadi Salim
2014-12-03 14:39 ` Jiri Pirko
2014-12-03 13:50 ` [patch net-next 0/6] net_sched: cls_*: couple of fixes Thomas Graf
2014-12-09 1:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F0AFA.7090001@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.