From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/6] vmdk: Clean up descriptor file reading
Date: Wed, 03 Dec 2014 15:16:00 +0100 [thread overview]
Message-ID: <547F1B20.7080809@redhat.com> (raw)
In-Reply-To: <1417602521-14482-4-git-send-email-famz@redhat.com>
On 2014-12-03 at 11:28, Fam Zheng wrote:
> Zeroing a buffer that will be filled right after is not necessary, and
> allocating a power of two + 1 is naughty.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/vmdk.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-12-03 14:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 10:28 [Qemu-devel] [PATCH v3 0/6] vmdk: A few small fixes Fam Zheng
2014-12-03 10:28 ` [Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID Fam Zheng
2014-12-03 14:11 ` Max Reitz
2014-12-03 17:06 ` Don Koch
2014-12-03 10:28 ` [Qemu-devel] [PATCH v3 2/6] vmdk: Fix comment to match code of extent lines Fam Zheng
2014-12-03 14:13 ` Max Reitz
2014-12-03 10:28 ` [Qemu-devel] [PATCH v3 3/6] vmdk: Clean up descriptor file reading Fam Zheng
2014-12-03 14:16 ` Max Reitz [this message]
2014-12-03 14:32 ` Markus Armbruster
2014-12-03 17:09 ` Don Koch
2014-12-03 10:28 ` [Qemu-devel] [PATCH v3 4/6] vmdk: Check descriptor file length when reading it Fam Zheng
2014-12-03 14:17 ` Max Reitz
2014-12-03 23:13 ` Fam Zheng
2014-12-03 10:28 ` [Qemu-devel] [PATCH v3 5/6] vmdk: Remove unnecessary initialization Fam Zheng
2014-12-03 14:18 ` Max Reitz
2014-12-03 17:10 ` Don Koch
2014-12-03 10:28 ` [Qemu-devel] [PATCH v3 6/6] vmdk: Set errp on failures in vmdk_open_vmdk4 Fam Zheng
2014-12-03 14:20 ` Max Reitz
2014-12-03 17:14 ` Don Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F1B20.7080809@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.