From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBae-00076B-AX for qemu-devel@nongnu.org; Wed, 03 Dec 2014 10:11:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwBaa-0003fc-G0 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 10:11:40 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:40401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBaa-0003fG-9W for qemu-devel@nongnu.org; Wed, 03 Dec 2014 10:11:36 -0500 Received: by mail-wi0-f182.google.com with SMTP id h11so24686104wiw.9 for ; Wed, 03 Dec 2014 07:11:34 -0800 (PST) Sender: Jiri Slaby Message-ID: <547F2824.7080001@suse.cz> Date: Wed, 03 Dec 2014 16:11:32 +0100 From: Jiri Slaby MIME-Version: 1.0 References: <5437C7C1.2010106@redhat.com> <1412942996-29645-1-git-send-email-jslaby@suse.cz> <543BCCFC.6050904@redhat.com> In-Reply-To: <543BCCFC.6050904@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 10/13/2014, 03:00 PM, Paolo Bonzini wrote: >> +static void edu_dma_timer(void *opaque) >> +{ >> + EduState *edu = opaque; >> + bool raise_irq = false; >> + >> + qemu_mutex_lock(&edu->dma_mutex); > > dma_mutex and mutex and irq_mutex are not necessary. All I/O happens > under the big QEMU lock (qemu_lock/unlock_iothread). I can certainly > imagine that edu.c would be one of the first devices we make > thread-safe, but... not yet. :) Hi, I finally got to it. I want to make sure that I understand this correctly. So even timers are protected by the "BQL"? thanks, -- js suse labs