From: Andrew Cooper <andrew.cooper3@citrix.com>
To: John Haxby <john.haxby@oracle.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] xen-detect: check for XEN_PV before XEN_HVM
Date: Wed, 3 Dec 2014 16:00:54 +0000 [thread overview]
Message-ID: <547F33B6.8090802@citrix.com> (raw)
In-Reply-To: <1417444646-20636-3-git-send-email-john.haxby@oracle.com>
On 01/12/14 14:37, John Haxby wrote:
> At some stage, the cpuid instruction used to detect a xen hvm domain
> also started working in a pv domain so pv domains were being identified
> as hvm (dom0 excepted). Change the order so that pv is tested for
> first.
>
> Signed-off-by: John Haxby <john.haxby@oracle.com>
This will have happened as a side effect of Intels CPUID-faulting
ability present in IvyBridge servers and later, which permits Xen the
ability to intercept regular cpuid instructions.
On the other hand, the forced emulation prefix is now valid in HVM
guests in debug Xens with the "hvm_fep" command line option. In that
case, the HVM domain would be erroneously identified as PV.
Perhaps it is worth having an explicit guest type available in the cpuid
leaves themselves, so guest userspace need not guess at all?
~Andrew
prev parent reply other threads:[~2014-12-03 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 14:37 Two miscellenous xen-detect patches John Haxby
2014-12-01 14:37 ` [PATCH 1/2] xen-detect: fix strict-aliasing compilation warning John Haxby
2014-12-01 17:15 ` Andrew Cooper
2014-12-01 18:45 ` John Haxby
2014-12-03 15:44 ` Andrew Cooper
2014-12-03 15:39 ` John Haxby
2014-12-03 15:51 ` Andrew Cooper
2014-12-01 14:37 ` [PATCH 2/2] xen-detect: check for XEN_PV before XEN_HVM John Haxby
2014-12-03 16:00 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F33B6.8090802@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=john.haxby@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.