From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Date: Thu, 04 Dec 2014 00:01:25 +0800 Message-ID: <547F33D5.2000905@rock-chips.com> References: <1417620408-30354-1-git-send-email-andy.yan@rock-chips.com> <1417620732-30593-1-git-send-email-andy.yan@rock-chips.com> <20141203154503.GD11285@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20141203154503.GD11285@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Russell King - ARM Linux Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com, Luc List-Id: devicetree@vger.kernel.org SGkgUnVzc2VsbDoKCk9uIDIwMTTlubQxMuaciDAz5pelIDIzOjQ1LCBSdXNzZWxsIEtpbmcgLSBB Uk0gTGludXggd3JvdGU6Cj4gT24gV2VkLCBEZWMgMDMsIDIwMTQgYXQgMTE6MzI6MTJQTSArMDgw MCwgQW5keSBZYW4gd3JvdGU6Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L0tjb25maWcgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcKPj4gaW5kZXggODg0OTIz Zi4uMjYxNjJlZiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9LY29uZmln Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvS2NvbmZpZwo+PiBAQCAtMywzICszLDgg QEAgY29uZmlnIERSTV9QVE4zNDYwCj4+ICAgCWRlcGVuZHMgb24gRFJNCj4+ICAgCXNlbGVjdCBE Uk1fS01TX0hFTFBFUgo+PiAgIAktLS1oZWxwLS0tCj4+ICsKPj4gK2NvbmZpZyBEUk1fRFdfSERN SQo+PiArCWJvb2wgIlN5bm9wc3lzIERlc2lnbldhcmUgSGlnaC1EZWZpbml0aW9uIE11bHRpbWVk aWEgSW50ZXJmYWNlIgo+PiArCWRlcGVuZHMgb24gRFJNCj4+ICsJc2VsZWN0IERSTV9LTVNfSEVM UEVSCj4gLi4uCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaW14L0tjb25maWcgYi9k cml2ZXJzL2dwdS9kcm0vaW14L0tjb25maWcKPj4gaW5kZXggODJmYjc1OC4uNzA3MDA3NyAxMDA2 NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2lteC9LY29uZmlnCj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pbXgvS2NvbmZpZwo+PiBAQCAtNDgsNiArNDgsNyBAQCBjb25maWcgRFJNX0lNWF9J UFVWMwo+PiAgIAo+PiAgIGNvbmZpZyBEUk1fSU1YX0hETUkKPj4gICAJdHJpc3RhdGUgIkZyZWVz Y2FsZSBpLk1YIERSTSBIRE1JIgo+PiArCXNlbGVjdCBEUk1fRFdfSERNSQo+PiAgIAlkZXBlbmRz IG9uIERSTV9JTVgKPj4gICAJaGVscAo+PiAgIAkgIENob29zZSB0aGlzIGlmIHlvdSB3YW50IHRv IHVzZSBIRE1JIG9uIGkuTVg2Lgo+IEknZCByZWNvbW1lbmQgdGhhdCBpZiB5b3Ugd2FudCB0byBz ZWxlY3QgRFJNX0RXX0hETUksIHRoZW4gZG9uJ3QgZ2l2ZQo+IERSTV9EV19IRE1JIGEgcHJvbXB0 IG1lc3NhZ2UuICBJIGFzc3VtZSB5b3UncmUgZ29pbmcgdG8gZG8gc29tZXRoaW5nCj4gc2ltaWxh ciB3aXRoIHlvdXIgUm9ja2NoaXAgZHJpdmVyIHRvbyAtIGluIHdoaWNoIGNhc2UgRFJNX0RXX0hE TUkgaXMKPiByZWFsbHkgYWJvdXQgYnVpbGRpbmcgYSBsaWJyYXJ5IG1vZHVsZS4KICAgRG8geW91 IG1lYW4gSSBqdXN0IG5lZXQgdG8gZG8gbGlrZSBiZWxsb3c/CgorCitjb25maWcgRFJNX0RXX0hE TUkKKwlib29sCisJZGVwZW5kcyBvbiBEUk0KKwlzZWxlY3QgRFJNX0tNU19IRUxQRVIKCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGlu ZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51 eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbaLCQBn (ORCPT ); Wed, 3 Dec 2014 11:01:43 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:44659 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbaLCQBl (ORCPT ); Wed, 3 Dec 2014 11:01:41 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: galak@codeaurora.org X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547F33D5.2000905@rock-chips.com> Date: Thu, 04 Dec 2014 00:01:25 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: airlied@linux.ie, Philipp Zabel , heiko@sntech.de, fabio.estevam@freescale.com, Greg Kroah-Hartman , Grant Likely , Rob Herring , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , Ian Campbell , vladimir_zapolskiy@mentor.com, Kumar Gala Subject: Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi References: <1417620408-30354-1-git-send-email-andy.yan@rock-chips.com> <1417620732-30593-1-git-send-email-andy.yan@rock-chips.com> <20141203154503.GD11285@n2100.arm.linux.org.uk> In-Reply-To: <20141203154503.GD11285@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell: On 2014年12月03日 23:45, Russell King - ARM Linux wrote: > On Wed, Dec 03, 2014 at 11:32:12PM +0800, Andy Yan wrote: >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index 884923f..26162ef 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -3,3 +3,8 @@ config DRM_PTN3460 >> depends on DRM >> select DRM_KMS_HELPER >> ---help--- >> + >> +config DRM_DW_HDMI >> + bool "Synopsys DesignWare High-Definition Multimedia Interface" >> + depends on DRM >> + select DRM_KMS_HELPER > ... >> diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig >> index 82fb758..7070077 100644 >> --- a/drivers/gpu/drm/imx/Kconfig >> +++ b/drivers/gpu/drm/imx/Kconfig >> @@ -48,6 +48,7 @@ config DRM_IMX_IPUV3 >> >> config DRM_IMX_HDMI >> tristate "Freescale i.MX DRM HDMI" >> + select DRM_DW_HDMI >> depends on DRM_IMX >> help >> Choose this if you want to use HDMI on i.MX6. > I'd recommend that if you want to select DRM_DW_HDMI, then don't give > DRM_DW_HDMI a prompt message. I assume you're going to do something > similar with your Rockchip driver too - in which case DRM_DW_HDMI is > really about building a library module. Do you mean I just neet to do like bellow? + +config DRM_DW_HDMI + bool + depends on DRM + select DRM_KMS_HELPER