From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode Date: Thu, 04 Dec 2014 00:30:23 +0800 Message-ID: <547F3A9F.30701@rock-chips.com> References: <1417620408-30354-1-git-send-email-andy.yan@rock-chips.com> <1417620566-30496-1-git-send-email-andy.yan@rock-chips.com> <20141203153847.GC11285@n2100.arm.linux.org.uk> <547F3495.9070206@rock-chips.com> <20141203161122.GF11285@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20141203161122.GF11285@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Russell King - ARM Linux Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com, Luc List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMuaciDA05pelIDAwOjExLCBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3Jv dGU6Cj4gT24gVGh1LCBEZWMgMDQsIDIwMTQgYXQgMTI6MDQ6MzdBTSArMDgwMCwgQW5keSBZYW4g d3JvdGU6Cj4+IEhpIFJ1c3NlbGw6Cj4+Cj4+IE9uIDIwMTTlubQxMuaciDAz5pelIDIzOjM4LCBS dXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3JvdGU6Cj4+PiBPbiBXZWQsIERlYyAwMywgMjAxNCBh dCAxMToyOToyNlBNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4+PiAraW50IGlteF9oZG1pX2Jp bmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4+Pj4gKwkJICB2 b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsCj4+Pj4gKwkJICBjb25zdCBz dHJ1Y3QgaW14X2hkbWlfcGxhdF9kYXRhICpwbGF0X2RhdGEpCj4+Pj4gICB7Cj4+Pj4gICAJc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiA9IHRvX3BsYXRmb3JtX2RldmljZShkZXYpOwo+Pj4+ IC0JY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCAqb2ZfaWQgPQo+Pj4+IC0JCQkJb2ZfbWF0Y2hf ZGV2aWNlKGlteF9oZG1pX2R0X2lkcywgZGV2KTsKPj4+PiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAq ZHJtID0gZGF0YTsKPj4+PiAgIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wID0gZGV2LT5vZl9ub2Rl Owo+Pj4+ICAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqZGRjX25vZGU7Cj4+Pj4gQEAgLTE1OTQsMTkg KzE1NjYsMTYgQEAgc3RhdGljIGludCBpbXhfaGRtaV9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwg c3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+Pj4+ICAgCXN0cnVjdCByZXNvdXJj ZSAqaW9yZXM7Cj4+Pj4gICAJaW50IHJldCwgaXJxOwo+Pj4+IC0JaGRtaSA9IGRldm1fa3phbGxv YyhkZXYsIHNpemVvZigqaGRtaSksIEdGUF9LRVJORUwpOwo+Pj4+ICsJaGRtaSA9IGRldm1fa3ph bGxvYygmcGRldi0+ZGV2LCBzaXplb2YoKmhkbWkpLCBHRlBfS0VSTkVMKTsKPj4+PiAgIAlpZiAo IWhkbWkpCj4+Pj4gICAJCXJldHVybiAtRU5PTUVNOwo+Pj4+IC0JaGRtaS0+ZGV2ID0gZGV2Owo+ Pj4+ICsJaGRtaS0+cGxhdF9kYXRhID0gcGxhdF9kYXRhOwo+Pj4+ICsJaGRtaS0+ZGV2ID0gJnBk ZXYtPmRldjsKPj4+PiArCWhkbWktPmRldl90eXBlID0gcGxhdF9kYXRhLT5kZXZfdHlwZTsKPj4+ PiAgIAloZG1pLT5zYW1wbGVfcmF0ZSA9IDQ4MDAwOwo+Pj4+ICAgCWhkbWktPnJhdGlvID0gMTAw Owo+Pj4+IC0KPj4+PiAtCWlmIChvZl9pZCkgewo+Pj4+IC0JCWNvbnN0IHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2VfaWQgKmRldmljZV9pZCA9IG9mX2lkLT5kYXRhOwo+Pj4+IC0KPj4+PiAtCQloZG1p LT5kZXZfdHlwZSA9IGRldmljZV9pZC0+ZHJpdmVyX2RhdGE7Cj4+Pj4gLQl9Cj4+Pj4gKwloZG1p LT5lbmNvZGVyID0gZW5jb2RlcjsKPj4+IEknZCBzdWdnZXN0IGNoYW5naW5nIGlteF9oZG1pX2Jp bmQoKSB0byB0YWtlIHRoZSBzdHJ1Y3QgcmVzb3VyY2UgYW5kIGlycQo+Pj4gbnVtYmVyLCBhbmQg YXZvaWRpbmcgdGhlIHBsYXRmb3JtIGRldmljZSBzdHVmZiBhbHRvZ2V0aGVyIGluIGhlcmUuCj4+ Pgo+PiAgICAgQWN0dWFsbHkgdGhpcyBpcyB3aGF0IHRoZSBjdXJyZW50IGNvZGUgZG86IHRoZSBy ZXNvdXJjZSBhbmQgaXJxIG51bWJlcgo+PiBhcmUgYWxsIGhhbmRsZWQgaW4gaW14X2hkbWlfYmlu ZAo+IEkgbWVhbnQgdGhhdCBpbXhfaGRtaV9iaW5kIHNob3VsZCBiZSBwYXNzZWQgdGhlc2UsIHNv IHRoYXQgaXQgbmVlZHMgdG8KPiBrbm93IG5vdGhpbmcgYWJvdXQgdGhlIHN0cnVjdCBkZXZpY2Ug YmV5b25kIHRoZSBnZW5lcmljIGRldmljZSBzdHJ1Y3R1cmUuCj4gSW4gb3RoZXIgd29yZHMsIHRo ZSBkdy1oZG1pIGNvcmUgc2hvdWxkIG5vdCBhc3N1bWUgdGhhdCB0aGUgc3RydWN0IGRldmljZQo+ IGlzIHBhcnQgb2YgYSBwbGF0Zm9ybSBkZXZpY2UuCj4KICAgIGlmIHNvLCBob3cgYWJvdXQgdGhl IGRldmljZSB0cmVlIHByb3BlcnRpZXMgIGRkYy1pMmMtYnVzLCAKcmVnLWlvLXdpZHRoLCBpYWhi LCBpc2ZyLAogICB0aGV5IGFyZSBhbGwgZm91bmQgYnkgZGV2aWNlPwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVs QGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006AbaLCQad (ORCPT ); Wed, 3 Dec 2014 11:30:33 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:53609 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbaLCQab (ORCPT ); Wed, 3 Dec 2014 11:30:31 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: galak@codeaurora.org X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <9e9eb0ebd5ebf6e75cce28db69ccb3b8> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547F3A9F.30701@rock-chips.com> Date: Thu, 04 Dec 2014 00:30:23 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: airlied@linux.ie, Philipp Zabel , heiko@sntech.de, fabio.estevam@freescale.com, Greg Kroah-Hartman , Grant Likely , Rob Herring , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , Ian Campbell , vladimir_zapolskiy@mentor.com, Kumar Gala Subject: Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode References: <1417620408-30354-1-git-send-email-andy.yan@rock-chips.com> <1417620566-30496-1-git-send-email-andy.yan@rock-chips.com> <20141203153847.GC11285@n2100.arm.linux.org.uk> <547F3495.9070206@rock-chips.com> <20141203161122.GF11285@n2100.arm.linux.org.uk> In-Reply-To: <20141203161122.GF11285@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年12月04日 00:11, Russell King - ARM Linux wrote: > On Thu, Dec 04, 2014 at 12:04:37AM +0800, Andy Yan wrote: >> Hi Russell: >> >> On 2014年12月03日 23:38, Russell King - ARM Linux wrote: >>> On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: >>>> +int imx_hdmi_bind(struct device *dev, struct device *master, >>>> + void *data, struct drm_encoder *encoder, >>>> + const struct imx_hdmi_plat_data *plat_data) >>>> { >>>> struct platform_device *pdev = to_platform_device(dev); >>>> - const struct of_device_id *of_id = >>>> - of_match_device(imx_hdmi_dt_ids, dev); >>>> struct drm_device *drm = data; >>>> struct device_node *np = dev->of_node; >>>> struct device_node *ddc_node; >>>> @@ -1594,19 +1566,16 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data) >>>> struct resource *iores; >>>> int ret, irq; >>>> - hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL); >>>> + hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL); >>>> if (!hdmi) >>>> return -ENOMEM; >>>> - hdmi->dev = dev; >>>> + hdmi->plat_data = plat_data; >>>> + hdmi->dev = &pdev->dev; >>>> + hdmi->dev_type = plat_data->dev_type; >>>> hdmi->sample_rate = 48000; >>>> hdmi->ratio = 100; >>>> - >>>> - if (of_id) { >>>> - const struct platform_device_id *device_id = of_id->data; >>>> - >>>> - hdmi->dev_type = device_id->driver_data; >>>> - } >>>> + hdmi->encoder = encoder; >>> I'd suggest changing imx_hdmi_bind() to take the struct resource and irq >>> number, and avoiding the platform device stuff altogether in here. >>> >> Actually this is what the current code do: the resource and irq number >> are all handled in imx_hdmi_bind > I meant that imx_hdmi_bind should be passed these, so that it needs to > know nothing about the struct device beyond the generic device structure. > In other words, the dw-hdmi core should not assume that the struct device > is part of a platform device. > if so, how about the device tree properties ddc-i2c-bus, reg-io-width, iahb, isfr, they are all found by device?