From: Eric Blake <eblake@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
ming.lei@canonical.com, armbru@redhat.com, mreitz@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] block: add accounting for merged requests
Date: Wed, 03 Dec 2014 10:39:05 -0700 [thread overview]
Message-ID: <547F4AB9.2000408@redhat.com> (raw)
In-Reply-To: <1417530788-15172-2-git-send-email-pl@kamp.de>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 12/02/2014 07:33 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block.c | 2 ++
> block/accounting.c | 7 +++++++
> block/qapi.c | 2 ++
> hmp.c | 6 +++++-
> include/block/accounting.h | 3 +++
> qapi/block-core.json | 10 +++++++++-
> 6 files changed, 28 insertions(+), 2 deletions(-)
Incomplete. qmp-commands.hx includes a query-blockstats example that
should be updated to show the output of the new non-optional fields.
> +# @wr_merged: Number of write requests that have been merged into another request
Longer than 80 columns; please wrap.
Otherwise looks good to me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-12-03 17:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 14:33 [Qemu-devel] [RFC PATCH 0/3] virtio-blk: add multiread support Peter Lieven
2014-12-02 14:33 ` [Qemu-devel] [RFC PATCH 1/3] block: add accounting for merged requests Peter Lieven
2014-12-03 17:39 ` Eric Blake [this message]
2014-12-02 14:33 ` [Qemu-devel] [RFC PATCH 2/3] hw/virtio-blk: add a constant for max number of " Peter Lieven
2014-12-02 14:33 ` [Qemu-devel] [RFC PATCH 3/3] virtio-blk: introduce multiread Peter Lieven
2014-12-03 17:25 ` Max Reitz
2014-12-04 7:16 ` Peter Lieven
2014-12-04 14:12 ` Kevin Wolf
2014-12-04 14:42 ` Peter Lieven
2014-12-04 15:03 ` Kevin Wolf
2014-12-04 15:11 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F4AB9.2000408@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.