From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwE0v-000871-9u for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwE0q-0003EN-7V for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:46:57 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:45101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwE0q-0003EA-1D for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:46:52 -0500 Message-ID: <547F4C81.1070301@imgtec.com> Date: Wed, 3 Dec 2014 17:46:41 +0000 From: Leon Alrae MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" , qemu-devel@nongnu.org Cc: Aurelien Jarno On 19/11/2014 14:20, Maciej W. Rozycki wrote: > - env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0; > + if (env->insn_flags & ISA_MIPS3) > + env->hflags |= MIPS_HFLAG_64; According to the CODING_STYLE braces are required even for a single statement "if" block. This also applies in other places in this patch. Otherwise, Reviewed-by: Leon Alrae