From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFuP-0001Hn-R3 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 14:48:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwFuK-00055u-UA for qemu-devel@nongnu.org; Wed, 03 Dec 2014 14:48:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFuK-00055o-Lt for qemu-devel@nongnu.org; Wed, 03 Dec 2014 14:48:16 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3JmFEv000701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 14:48:16 -0500 Message-ID: <547F68FE.1000809@redhat.com> Date: Wed, 03 Dec 2014 12:48:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-15-git-send-email-mreitz@redhat.com> In-Reply-To: <1417613866-25890-15-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bSliJwpsbqR24vPvvicd1ICoHXMkiQxBs" Subject: Re: [Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_amend_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bSliJwpsbqR24vPvvicd1ICoHXMkiQxBs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2014 06:37 AM, Max Reitz wrote: > qcow2_amend_options() should not compare options against some inline > strings but rather use the symbolic macros available for each of the > creation options. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bSliJwpsbqR24vPvvicd1ICoHXMkiQxBs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUf2j+AAoJEKeha0olJ0NqplUH/0JhfOa1qXuYXQ/n7CynitQi QHSycrDwreuYpJ8iXyRuW+DIjtuTtrXbTdvHgHM9GhECJ+VhD4Lh6mVr4Y8rcXDo 4zHFMgmAkI4zG6An4LCY/YLtHJd0x01F6W8YwY9rpuU4XsLVb5ostKM6UUKID8Vg 53G62dUkSJ2jywa+Czdo1fODh3dDsw3C2kA5Py0gFnBm0Idtjb7UH1SmEhikHE2d QM4o+FPCjjs4I8RSvyGQcFKzCn3uy/enbbyrCAqejtcHLxmbgflNbc0BW5RT1jdJ 6NMxLsG+jhQZOD+YFum6vfnGzWHzOjnQctVMJ0t0te2J9sdC1RFEtQ4v3CFcBL4= =4J9A -----END PGP SIGNATURE----- --bSliJwpsbqR24vPvvicd1ICoHXMkiQxBs--