All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shiqun.Lin" <Shiqun.Lin@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 1/1] improve the sanity check for PATH and BBPATH
Date: Thu, 4 Dec 2014 10:29:13 +0800	[thread overview]
Message-ID: <547FC6F9.3050609@windriver.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: 0001-improve-the-sanity-check-for-PATH-and-BBPATH.patch --]
[-- Type: text/x-patch, Size: 2088 bytes --]

From 583f97149ed3122e7b196f08c6bceca9d5a4961c Mon Sep 17 00:00:00 2001
From: Shiqun Lin <Shiqun.Lin@windriver.com>
Date: Thu, 4 Dec 2014 09:50:18 +0800
Subject: [PATCH] improve the sanity check for PATH and BBPATH

Issue: LIN5-19447, Build fails if "./" is in the PATH

a customer was using "./" in his PATH, and this breaks the build.

$ export PATH="./:$PATH"
$ make -C build-tools elfutils

Signed-off-by: Shiqun Lin <Shiqun.Lin@windriver.com>
---
 meta/classes/sanity.bbclass | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index c2e7bee..1ade542 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -388,15 +388,15 @@ def check_sanity(sanity_data):
             messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
 
     paths = sanity_data.getVar('PATH', True).split(":")
-    if "." in paths or "" in paths:
-        messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
+    if "." in paths or "./" in paths or "" in paths:
+        messages = messages + "PATH contains '.', './' or '', which will break the build, please remove this."
 
     bbpaths = sanity_data.getVar('BBPATH', True).split(":")
-    if "." in bbpaths or "" in bbpaths:
+    if "." in bbpaths or "./" in bbpaths or "" in bbpaths:
         # TODO: change the following message to fatal when all BBPATH issues
         # are fixed
         bb.warn("BBPATH references the current directory, either through "    \
-                "an empty entry, or a '.'.\n\t This is unsafe and means your "\
+                "an empty entry, a './', or a '.'.\n\t This is unsafe and means your "\
                 "layer configuration is adding empty elements to BBPATH.\n\t "\
                 "Please check your layer.conf files and other BBPATH "        \
                 "settings to remove the current working directory "           \
-- 
1.8.5.2.233.g932f7e4


             reply	other threads:[~2014-12-04  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:29 Shiqun.Lin [this message]
2014-12-04 17:28 ` [PATCH 1/1] improve the sanity check for PATH and BBPATH Burton, Ross
2015-05-19  2:28   ` wenzong fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547FC6F9.3050609@windriver.com \
    --to=shiqun.lin@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.