From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwQSd-00034T-NL for qemu-devel@nongnu.org; Thu, 04 Dec 2014 02:04:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwQSX-00028p-IR for qemu-devel@nongnu.org; Thu, 04 Dec 2014 02:04:23 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:38240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwQSW-00028G-SR for qemu-devel@nongnu.org; Thu, 04 Dec 2014 02:04:17 -0500 Message-ID: <5480075A.4090701@huawei.com> Date: Thu, 4 Dec 2014 15:03:54 +0800 From: Gonglei MIME-Version: 1.0 References: <1417674851-6248-1-git-send-email-arei.gonglei@huawei.com> <20141204065144.GC10914@air.redhat.com> In-Reply-To: <20141204065144.GC10914@air.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block/rbd: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: "kwolf@redhat.com" , "josh.durgin@inktank.com" , "qemu-devel@nongnu.org" , "stefanha@redhat.com" , Markus Armbruster On 2014/12/4 14:51, Amos Kong wrote: > 'local_err' was defined for collecting error insider qemu_opts_absorb_qdict(). > We should set error to 'errp', then the error can be passed to caller, > and free the memory in future. > > Reviewed-by: Amos Kong Thanks :) Regards, -Gonglei