All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>,
	Eugene Korenevsky <ekorenevsky@gmail.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: vmx: add checks on guest RIP
Date: Thu, 04 Dec 2014 08:41:24 +0100	[thread overview]
Message-ID: <54801024.2050504@redhat.com> (raw)
In-Reply-To: <547F9513.3090600@amacapital.net>



On 03/12/2014 23:56, Andy Lutomirski wrote:
> > This check is off by one.  It is checking bits 63:47 instead of bits
> > 63:48 (this quirk is intentionally part of the specification, so that
> > you can reenter a guest at 0x800000000000 after e.g. a VMCALL vmexit and
> > cause a general protection fault).
> 
> Seriously?  Intel did that for vmcall but not sysret?

Yes, it is even tested by kvm-unit-tests. :)

Paolo

      reply	other threads:[~2014-12-04  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29 15:27 [PATCH] kvm: x86: vmx: add checks on guest RIP Eugene Korenevsky
2014-12-01 16:27 ` Paolo Bonzini
2014-12-03 22:56   ` Andy Lutomirski
2014-12-04  7:41     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54801024.2050504@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ekorenevsky@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=luto@amacapital.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.