From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwSH5-00013k-6L for qemu-devel@nongnu.org; Thu, 04 Dec 2014 04:00:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwSGy-0006aD-RO for qemu-devel@nongnu.org; Thu, 04 Dec 2014 04:00:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwSGy-0006a7-JX for qemu-devel@nongnu.org; Thu, 04 Dec 2014 04:00:28 -0500 Message-ID: <548022A9.3090700@redhat.com> Date: Thu, 04 Dec 2014 10:00:25 +0100 From: Max Reitz MIME-Version: 1.0 References: <1417649314-13704-1-git-send-email-famz@redhat.com> <1417649314-13704-5-git-send-email-famz@redhat.com> In-Reply-To: <1417649314-13704-5-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Don Koch , Markus Armbruster , Stefan Hajnoczi On 2014-12-04 at 00:28, Fam Zheng wrote: > Since a too small file cannot be a valid VMDK image, and also since the > buffer's first 4 bytes will be unconditionally examined by > vmdk_open_sparse, let's error out the small file case to be clear. > > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Reviewed-by: Max Reitz