From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yu, Zhang" Subject: Re: [PATCH v4] x86: add p2m_mmio_write_dm Date: Thu, 04 Dec 2014 17:42:40 +0800 Message-ID: <54802C90.1030401@linux.intel.com> References: <1417161552-5155-1-git-send-email-yu.c.zhang@linux.intel.com> <54785525020000780004B588@mail.emea.novell.com> <547C2BAF.6010004@linux.intel.com> <547C43BA020000780004B9BE@mail.emea.novell.com> <20141201103012.GA69236@deinos.phlegethon.org> <547C5C43020000780004BAFD@mail.emea.novell.com> <20141201121300.GB69236@deinos.phlegethon.org> <547D6C86.4090400@linux.intel.com> <20141202114016.GD69236@deinos.phlegethon.org> <548022DE.3090906@linux.intel.com> <20141204093600.GA35555@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141204093600.GA35555@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, donald.d.dugger@intel.com, Xen-devel@lists.xen.org, Paul.Durrant@citrix.com, zhiyuan.lv@intel.com, Jan Beulich , yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 12/4/2014 5:36 PM, Tim Deegan wrote: > Hi, > > At 17:01 +0800 on 04 Dec (1417708878), Yu, Zhang wrote: >> I just noticed that in __hvm_copy()/__hvm_clear(), the grant types are >> handled before the p2m_ram_ro - will return HVMCOPY_unhandleable. So if >> p2m_is_discard_write() is supposed to replace the handling of >> p2m_ram_ro, handling of p2m_grant_map_ro will still return >> HVMCOPY_unhandleable, before the p2m_is_discard_write() predicate. >> Even we move the testing of p2m_is_discard_write() before the handling >> of grant types, it seems not quite clean. >> By "over-strict in their failure to handle grant types.", do you also >> mean this? > > Yes, that's the sort of thing I meant. I'll try to write a patch for > that later today or next week -- in the meantime I think you should > ignore it. :) > > An unrelated thought: when you send your next version can you send it > as a two-patch series, where the first patch does the > p2m_is_discard_write() changes and the second adds your new type? Sure, and thank you, Tim. :) > > Cheers, > > Tim. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > >