From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [v4] libxc: Expose the 1GB pages cpuid flag to guest Date: Thu, 4 Dec 2014 10:21:15 +0000 Message-ID: <5480359B.1030609@citrix.com> References: <1417171925-10102-1-git-send-email-liang.z.li@intel.com> <1417175443.23604.18.camel@citrix.com> <20141202210941.GA1593@laptop.dumpdata.com> <1417599529.29004.16.camel@citrix.com> <20141203155744.GE3081@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Zhang, Yang Z" , Konrad Rzeszutek Wilk , Ian Campbell Cc: "wei.liu2@citrix.com" , "stefano.stabellini@eu.citrix.com" , "tim@xen.org" , "Li, Liang Z" , "ian.jackson@eu.citrix.com" , "xen-devel@lists.xen.org" , "JBeulich@suse.com" List-Id: xen-devel@lists.xenproject.org On 04/12/14 01:50, Zhang, Yang Z wrote: > Konrad Rzeszutek Wilk wrote on 2014-12-03: >> On Wed, Dec 03, 2014 at 09:38:49AM +0000, Ian Campbell wrote: >>> On Tue, 2014-12-02 at 16:09 -0500, Konrad Rzeszutek Wilk wrote: >>>> On Fri, Nov 28, 2014 at 11:50:43AM +0000, Ian Campbell wrote: >>>>> On Fri, 2014-11-28 at 18:52 +0800, Liang Li wrote: >>>>>> If hardware support the 1GB pages, expose the feature to guest by >>>>>> default. Users don't have to use a 'cpuid= ' option in config fil >>>>>> e to turn it on. >>>>>> >>>>>> If guest use shadow mode, the 1GB pages feature will be hidden from >>>>>> guest, this is done in the function hvm_cpuid(). So the change is >>>>>> okay for shadow mode case. >>>>>> >>>>>> Signed-off-by: Liang Li >>>>>> Signed-off-by: Yang Zhang >>>>> FTR although this is strictly speaking a toolstack patch I think the >>>>> main ack required should be from the x86 hypervisor guys... >>>> Jan acked it. >>> For 4.5? >> Probably not. >>> Have you release acked it? >> No. >>> This seemed like 4.6 material to me, or at least I've not seen any >>> mention/argument to the contrary. >> Correct. 4.6 please. > I think this more like a bug fixing than a feature. See our previous discussion. It is allowing HVM guests to use a brand new hardware feature which was previously unavailable to them. It is absolutely not a bugfix, and not appropriate for 4.5 at this point, but a good candidate for acceptance as soon as the 4.6 dev window opens. ~Andrew