From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 4/9] xen: introduce XEN_DOMCTL_devour
Date: Thu, 04 Dec 2014 11:01:00 +0000
Message-ID: <54803EEC.5040404@linaro.org>
References: <1417626981-8432-1-git-send-email-vkuznets@redhat.com>
	<1417626981-8432-5-git-send-email-vkuznets@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1XwU9g-0005uN-CZ
	for xen-devel@lists.xenproject.org; Thu, 04 Dec 2014 11:01:04 +0000
Received: by mail-wg0-f41.google.com with SMTP id y19so22367606wgg.0
	for <xen-devel@lists.xenproject.org>;
	Thu, 04 Dec 2014 03:01:02 -0800 (PST)
In-Reply-To: <1417626981-8432-5-git-send-email-vkuznets@redhat.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vitaly Kuznetsov <vkuznets@redhat.com>, xen-devel@lists.xenproject.org
Cc: Andrew Jones <drjones@redhat.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org



On 03/12/2014 17:16, Vitaly Kuznetsov wrote:
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index a42d0b8..552e4a3 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -366,6 +366,8 @@ struct domain
>       bool_t           is_privileged;
>       /* Which guest this guest has privileges on */
>       struct domain   *target;
> +    /* Which guest receives freed memory pages */

It took me a while to understand that the recipient domain is a newly 
created domain, right? It might be worth to add a word here (and maybe 
in assign_pages).

With that in mind, the code in assign_pages makes more sense.

Regards,

-- 
Julien Grall