From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH] amdkfd: use atomic allocations within srcu callbacks Date: Thu, 4 Dec 2014 14:27:44 +0200 Message-ID: <54805340.9010003@amd.com> References: <1417619976-8498-1-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0146.outbound.protection.outlook.com [65.55.169.146]) by gabe.freedesktop.org (Postfix) with ESMTP id 3836E6E5EB for ; Thu, 4 Dec 2014 04:28:06 -0800 (PST) In-Reply-To: <1417619976-8498-1-git-send-email-sasha.levin@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sasha Levin Cc: Andrew.Lewycky@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMi8wMy8yMDE0IDA1OjE5IFBNLCBTYXNoYSBMZXZpbiB3cm90ZToKPiBzcmN1IGNhbGxi YWNrcyBhcmUgcnVubmluZyBpbiBhdG9taWMgY29udGV4dCwgd2UgY2FuJ3QgYWxsb2NhdGUgdXNp bmcKPiBfX0dGUF9XQUlULgo+Cj4gU2lnbmVkLW9mZi1ieTogU2FzaGEgTGV2aW4gPHNhc2hhLmxl dmluQG9yYWNsZS5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRf cHJvY2Vzcy5jIHwgMiArLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2Zk X3Byb2Nlc3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9wcm9jZXNzLmMKPiBp bmRleCBiNGY0OWFjLi5iODVlYjBiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1ka2ZkL2tmZF9wcm9jZXNzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9r ZmRfcHJvY2Vzcy5jCj4gQEAgLTE5Niw3ICsxOTYsNyBAQCBzdGF0aWMgdm9pZCBrZmRfcHJvY2Vz c19kZXN0cm95X2RlbGF5ZWQoc3RydWN0IHJjdV9oZWFkICpyY3UpCj4gICAJbW1kcm9wKHAtPm1t KTsKPgo+ICAgCXdvcmsgPSAoc3RydWN0IGtmZF9wcm9jZXNzX3JlbGVhc2Vfd29yayAqKQo+IC0J CWttYWxsb2Moc2l6ZW9mKHN0cnVjdCBrZmRfcHJvY2Vzc19yZWxlYXNlX3dvcmspLCBHRlBfS0VS TkVMKTsKPiArCQlrbWFsbG9jKHNpemVvZihzdHJ1Y3Qga2ZkX3Byb2Nlc3NfcmVsZWFzZV93b3Jr KSwgR0ZQX0FUT01JQyk7Cj4KPiAgIAlpZiAod29yaykgewo+ICAgCQlJTklUX1dPUksoKHN0cnVj dCB3b3JrX3N0cnVjdCAqKSB3b3JrLCBrZmRfcHJvY2Vzc193cV9yZWxlYXNlKTsKPgoKVGhhbmtz IQpBcHBsaWVkIHRvIG15IC1uZXh0IHRyZWUuCgpPZGVkCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932152AbaLDM2J (ORCPT ); Thu, 4 Dec 2014 07:28:09 -0500 Received: from mail-bl2on0111.outbound.protection.outlook.com ([65.55.169.111]:44448 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932078AbaLDM2H (ORCPT ); Thu, 4 Dec 2014 07:28:07 -0500 X-WSS-ID: 0NG25AP-07-EB6-02 X-M-MSG: Message-ID: <54805340.9010003@amd.com> Date: Thu, 4 Dec 2014 14:27:44 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sasha Levin CC: , , , , , , , Subject: Re: [PATCH] amdkfd: use atomic allocations within srcu callbacks References: <1417619976-8498-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1417619976-8498-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.0.84] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(41574002)(377454003)(479174003)(199003)(189002)(51704005)(24454002)(46102003)(50466002)(59896002)(117636001)(23676002)(50986999)(101416001)(99136001)(54356999)(65816999)(110136001)(102836001)(87266999)(92566001)(86362001)(92726001)(575784001)(21056001)(83506001)(76176999)(4396001)(64126003)(19580395003)(19580405001)(87936001)(84676001)(20776003)(47776003)(64706001)(105586002)(65806001)(106466001)(77156002)(62966003)(95666004)(97736003)(107046002)(99396003)(120916001)(77096005)(31966008)(68736005)(36756003)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR02MB195;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB195; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601001);SRVR:BLUPR02MB195; X-Forefront-PRVS: 041517DFAB Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Oded.Gabbay@amd.com; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB195; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2014 05:19 PM, Sasha Levin wrote: > srcu callbacks are running in atomic context, we can't allocate using > __GFP_WAIT. > > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > index b4f49ac..b85eb0b 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > @@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu) > mmdrop(p->mm); > > work = (struct kfd_process_release_work *) > - kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL); > + kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC); > > if (work) { > INIT_WORK((struct work_struct *) work, kfd_process_wq_release); > Thanks! Applied to my -next tree. Oded