From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v17 06/12] dt-bindings: add document for dw_hdmi Date: Thu, 04 Dec 2014 21:27:44 +0800 Message-ID: <54806150.6020206@rock-chips.com> References: <1417686826-12687-1-git-send-email-andy.yan@rock-chips.com> <1417687565-13206-1-git-send-email-andy.yan@rock-chips.com> <1417692637.3744.5.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417692637.3744.5.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKT24gMjAxNOW5tDEy5pyIMDTml6UgMTk6MzAsIFBoaWxpcHAgWmFiZWwgd3Jv dGU6Cj4gSGkgQW5keSwKPgo+IEFtIERvbm5lcnN0YWcsIGRlbiAwNC4xMi4yMDE0LCAxODowNiAr MDgwMCBzY2hyaWViIEFuZHkgWWFuOgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmR5IFlhbiA8YW5keS55 YW5Acm9jay1jaGlwcy5jb20+Cj4+Cj4+IC0tLQo+Pgo+PiBDaGFuZ2VzIGluIHYxNzogTm9uZQo+ PiBDaGFuZ2VzIGluIHYxNjoKPj4gLSBkZXNjcmliZSBkZGMtaTJjLWJ1cyBhcyBvcHRpb25hbAo+ PiAtIGFkZCBjb21tb24gY2xvY2tzIGJpbmRpbmdzCj4+Cj4+IENoYW5nZXMgaW4gdjE1OiBOb25l Cj4+IENoYW5nZXMgaW4gdjE0OiBOb25lCj4+IENoYW5nZXMgaW4gdjEzOiBOb25lCj4+IENoYW5n ZXMgaW4gdjEyOiBOb25lCj4+IENoYW5nZXMgaW4gdjExOiBOb25lCj4+IENoYW5nZXMgaW4gdjEw OiBOb25lCj4+IENoYW5nZXMgaW4gdjk6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2ODoKPj4gLSBjb3Jy ZWN0IHNvbWUgc3BlbGxpbmcgbWlzdGFrZQo+PiAtIG1vZGlmeSBkZGMtaTJjLWJ1cyBhbmQgaW50 ZXJydXB0IGRlc2NyaXB0aW9uCj4+Cj4+IENoYW5nZXMgaW4gdjc6IE5vbmUKPj4gQ2hhbmdlcyBp biB2NjogTm9uZQo+PiBDaGFuZ2VzIGluIHY1OiBOb25lCj4+IENoYW5nZXMgaW4gdjQ6IE5vbmUK Pj4gQ2hhbmdlcyBpbiB2MzogTm9uZQo+Pgo+PiAgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Ry bS9icmlkZ2UvZHdfaGRtaS50eHQgICAgIHwgNDUgKysrKysrKysrKysrKysrKysrKysrKwo+PiAg IDEgZmlsZSBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspCj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0 IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hkbWkudHh0 Cj4+Cj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHJt L2JyaWRnZS9kd19oZG1pLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k cm0vYnJpZGdlL2R3X2hkbWkudHh0Cj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+IGluZGV4IDAw MDAwMDAuLmZiMTQ3MzAKPj4gLS0tIC9kZXYvbnVsbAo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kd19oZG1pLnR4dAo+PiBAQCAtMCwwICsxLDQ1 IEBACj4+ICtEZXNpZ25XYXJlIEhETUkgYnJpZGdlIGJpbmRpbmdzCj4+ICsKPj4gK1JlcXVpcmVk IHByb3Blcml0aWVzOgo+PiArLSBjb21wYXRpYmxlOiBwbGF0Zm9ybSBzcGVjaWZpYyBzdWNoIGFz Ogo+PiArICAgKiAic25wcyxkdy1oZG1pLXR4Igo+PiArICAgKiAiZnNsLGlteDZxLWhkbWkiCj4+ ICsgICAqICJmc2wsaW14NmRsLWhkbWkiCj4+ICsgICAqICJyb2NrY2hpcCxyazMyODgtZHctaGRt aSIKPj4gKy0gcmVnOiBQaHlzaWNhbCBiYXNlIGFkZHJlc3MgYW5kIGxlbmd0aCBvZiB0aGUgY29u dHJvbGxlcidzIHJlZ2lzdGVycy4KPj4gKy0gaW50ZXJydXB0czogVGhlIEhETUkgaW50ZXJydXB0 IG51bWJlcgo+PiArLSBjbG9ja3MsIGNsb2NrLW5hbWVzIDogbXVzdCBoYXZlIHRoZSBwaGFuZGxl cyB0byB0aGUgSERNSSBpYWhiIGFuZCBpc3JmIGNsb2NrcywKPj4gKyAgYXMgZGVzY3JpYmVkIGlu IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9jbG9jay1iaW5kaW5ncy50 eHQsCj4+ICsgIHRoZSBjbG9jay1uYW1lcyBzaG91bGQgYmUgImlhaGIiLCAiaXNmciIKPiBUaGlz IGlzIG1pc3NpbmcgdGhlIHBvcnQgYmluZGluZ3MsIEkgdGhpbmsgaXQgc2hvdWxkIG1lbnRpb24g dGhlIHBvcnQKPiBwcm9wZXJ0eSBoZXJlIGFuZCByZWZlciB0byB0aGUgc29jIHNwZWNpZmljIGJp bmRpbmcgZG9jdW1lbnQuCj4KPiAgIC0gcG9ydEAuLi46IFNvQyBzcGVjaWZpYyBwb3J0IG5vZGVz IHdpdGggZW5kcG9pbnQgZGVmaW5pdGlvbnMgYXMgZGVmaW5lZAo+ICAgICBpbiBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvdmlkZW8taW50ZXJmYWNlcy50eHQsCj4gICAg IHBsZWFzZSByZWZlciB0byB0aGUgU29DIHNwZWNpZmljIGJpbmRpbmcgZG9jdW1lbnQ6Cj4gICAg ICAqIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vaW14L2hkbWkudHh0Cj4g ICAgICAqIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy92aWRlby9kd19oZG1pLXJv Y2tjaGlwLnR4dAo+Cj4gVGhpcyBhbHNvIG1ha2VzIGJlIHdvbmRlciwgc2hvdWxkbid0IGR3X2hk bWktcm9ja2NoaXAgYmUgdW5kZXIgZHJtLz8KICAgIG9rLCBJIHdpbGwgYWRkIHRoZSBwb3J0IGJp bmRpbmdzCiAgICBiZWNhdXNlIHJvY2tjaGlwIGRybSBiaW5kcyBhcmUgdW5kZXIgdmlkZW8sIHNv IEkgcHV0IHRoZSAKZHdfaGRtaS1yb2NrY2hpcAogICAgdW5kZXIgdmlkZW8gdG8ga2VlcCBjb25z aXN0ZW5jeS4KPgo+PiArT3B0aW9uYWwgcHJvcGVydGllcwo+PiArLSByZWctaW8td2lkdGg6IHRo ZSB3aWR0aCBvZiB0aGUgcmVnOjEsNCwgZGVmYXVsdCBzZXQgdG8gMSBpZiBub3QgcHJlc2VudAo+ PiArLSBkZGMtaTJjLWJ1czogcGhhbmRsZSBvZiBhbiBJMkMgY29udHJvbGxlciB1c2VkIGZvciBE REMgRURJRCBwcm9iaW5nCj4+ICstIGNsa29ja3MsIGNsb2NrLW5hbWVzOiBwaGFuZGxlIHRvIHRo ZSBIRE1JIGNlYyBjbG9jaywgbmFtZSBzaG91bGQgYmUgImNlYyIKPiBzL2Nsa29ja3MvY2xvY2tz LywgYW5kIEknZCB1cHBlcmNhc2UgdGhlIEhETUkgQ0VDIGNsb2NrIGZvciBjb25zaXN0ZW5jeS4K ICAgICB0aGFua3MgZm9yIHBvaW50IGl0LCBJIHdpbGwgY29ycmVjdCBpdCBpbiBuZXh0IHZlcnNp b24KPgo+PiArCj4+ICtFeGFtcGxlOgo+PiArCWhkbWk6IGhkbWlAMDEyMDAwMCB7Cj4+ICsJCWNv bXBhdGlibGUgPSAiZnNsLGlteDZxLWhkbWkiOwo+IENvdWxkIHlvdSBjaGFuZ2UgdGhpcyBleGFt cGxlIHRvOgo+IAkJY29tcGF0aWJsZSA9ICJmc2wsaW14NnEtaGRtaSIsICJzbnBzLGR3LWhkbWkt dHgiCj4KPj4gKwkJcmVnID0gPDB4MDAxMjAwMDAgMHg5MDAwPjsKPj4gKwkJaW50ZXJydXB0cyA9 IDwwIDExNSAweDA0PjsKPj4gKwkJZ3ByID0gPCZncHI+Owo+PiArCQljbG9ja3MgPSA8JmNsa3Mg MTIzPiwgPCZjbGtzIDEyND47Cj4+ICsJCWNsb2NrLW5hbWVzID0gImlhaGIiLCAiaXNmciI7Cj4+ ICsJCWRkYy1pMmMtYnVzID0gPCZpMmMyPjsKPj4gKwo+PiArCQlwb3J0QDAgewo+PiArCQkJcmVn ID0gPDA+Owo+PiArCj4+ICsJCQloZG1pX211eF8wOiBlbmRwb2ludCB7Cj4+ICsJCQkJcmVtb3Rl LWVuZHBvaW50ID0gPCZpcHUxX2RpMF9oZG1pPjsKPj4gKwkJCX07Cj4+ICsJCX07Cj4+ICsKPj4g KwkJcG9ydEAxIHsKPj4gKwkJCXJlZyA9IDwxPjsKPj4gKwo+PiArCQkJaGRtaV9tdXhfMTogZW5k cG9pbnQgewo+PiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmaXB1MV9kaTFfaGRtaT47Cj4+ICsJ CQl9Owo+PiArCQl9Owo+PiArCX07Cj4KPgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2 ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbaLDN2G (ORCPT ); Thu, 4 Dec 2014 08:28:06 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:40930 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbaLDN1z (ORCPT ); Thu, 4 Dec 2014 08:27:55 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: vladimir_zapolskiy@mentor.com X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <088d1b3a3d8d7cae66ec141fd249fd79> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54806150.6020206@rock-chips.com> Date: Thu, 04 Dec 2014 21:27:44 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk, Greg Kroah-Hartman , Grant Likely , Rob Herring , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , Ian Campbell , Kumar Gala , vladimir_zapolskiy@mentor.com Subject: Re: [PATCH v17 06/12] dt-bindings: add document for dw_hdmi References: <1417686826-12687-1-git-send-email-andy.yan@rock-chips.com> <1417687565-13206-1-git-send-email-andy.yan@rock-chips.com> <1417692637.3744.5.camel@pengutronix.de> In-Reply-To: <1417692637.3744.5.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年12月04日 19:30, Philipp Zabel wrote: > Hi Andy, > > Am Donnerstag, den 04.12.2014, 18:06 +0800 schrieb Andy Yan: >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v17: None >> Changes in v16: >> - describe ddc-i2c-bus as optional >> - add common clocks bindings >> >> Changes in v15: None >> Changes in v14: None >> Changes in v13: None >> Changes in v12: None >> Changes in v11: None >> Changes in v10: None >> Changes in v9: None >> Changes in v8: >> - correct some spelling mistake >> - modify ddc-i2c-bus and interrupt description >> >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> >> .../devicetree/bindings/drm/bridge/dw_hdmi.txt | 45 ++++++++++++++++++++++ >> 1 file changed, 45 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> >> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> new file mode 100644 >> index 0000000..fb14730 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> @@ -0,0 +1,45 @@ >> +DesignWare HDMI bridge bindings >> + >> +Required properities: >> +- compatible: platform specific such as: >> + * "snps,dw-hdmi-tx" >> + * "fsl,imx6q-hdmi" >> + * "fsl,imx6dl-hdmi" >> + * "rockchip,rk3288-dw-hdmi" >> +- reg: Physical base address and length of the controller's registers. >> +- interrupts: The HDMI interrupt number >> +- clocks, clock-names : must have the phandles to the HDMI iahb and isrf clocks, >> + as described in Documentation/devicetree/bindings/clock/clock-bindings.txt, >> + the clock-names should be "iahb", "isfr" > This is missing the port bindings, I think it should mention the port > property here and refer to the soc specific binding document. > > - port@...: SoC specific port nodes with endpoint definitions as defined > in Documentation/devicetree/bindings/media/video-interfaces.txt, > please refer to the SoC specific binding document: > * Documentation/devicetree/bindings/drm/imx/hdmi.txt > * Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt > > This also makes be wonder, shouldn't dw_hdmi-rockchip be under drm/? ok, I will add the port bindings because rockchip drm binds are under video, so I put the dw_hdmi-rockchip under video to keep consistency. > >> +Optional properties >> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >> +- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing >> +- clkocks, clock-names: phandle to the HDMI cec clock, name should be "cec" > s/clkocks/clocks/, and I'd uppercase the HDMI CEC clock for consistency. thanks for point it, I will correct it in next version > >> + >> +Example: >> + hdmi: hdmi@0120000 { >> + compatible = "fsl,imx6q-hdmi"; > Could you change this example to: > compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx" > >> + reg = <0x00120000 0x9000>; >> + interrupts = <0 115 0x04>; >> + gpr = <&gpr>; >> + clocks = <&clks 123>, <&clks 124>; >> + clock-names = "iahb", "isfr"; >> + ddc-i2c-bus = <&i2c2>; >> + >> + port@0 { >> + reg = <0>; >> + >> + hdmi_mux_0: endpoint { >> + remote-endpoint = <&ipu1_di0_hdmi>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + hdmi_mux_1: endpoint { >> + remote-endpoint = <&ipu1_di1_hdmi>; >> + }; >> + }; >> + }; > > > >