From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kvm: cpuid: fix xsave area size of XSAVEC
Date: Thu, 04 Dec 2014 14:57:13 +0100 [thread overview]
Message-ID: <54806839.1080301@redhat.com> (raw)
In-Reply-To: <1417681468-7165-3-git-send-email-wanpeng.li@linux.intel.com>
On 04/12/2014 09:24, Wanpeng Li wrote:
> XSAVEC also use the compacted format for the extended region
> of the XSAVE area. This patch fix it by caculate the size of
> XSAVEC extended region of XSAVE area as compact format.
>
> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
> ---
> arch/x86/kvm/cpuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index 70f0fa1..e16a0c7 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -92,7 +92,7 @@ int kvm_update_cpuid(struct kvm_vcpu *vcpu)
> }
>
> best = kvm_find_cpuid_entry(vcpu, 0xD, 1);
> - if (best && (best->eax & F(XSAVES)))
> + if (best && (best->eax & (F(XSAVES) || F(XSAVEC))))
"|" instead of "||" as mentioned by Nadav.
Is the Intel manual implicitly relying on the fact that there is no
processor that has XSAVES but not XSAVEC?
Paolo
> best->ebx = xstate_required_size(vcpu->arch.xcr0, true);
>
> /*
>
next prev parent reply other threads:[~2014-12-04 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 8:24 [PATCH 1/4] kvm: vmx: add nested virtualization support for xsaves Wanpeng Li
2014-12-04 8:24 ` [PATCH 2/4] kvm: cpuid: fix the size of xsaves area Wanpeng Li
2014-12-04 13:55 ` Paolo Bonzini
2014-12-04 13:59 ` Paolo Bonzini
2014-12-04 8:24 ` [PATCH 3/4] kvm: cpuid: fix xsave area size of XSAVEC Wanpeng Li
2014-12-04 8:30 ` Nadav Amit
2014-12-04 8:54 ` Wanpeng Li
2014-12-04 13:57 ` Paolo Bonzini [this message]
2014-12-04 8:24 ` [PATCH 4/4] kvm: vmx: fix VMfailValid when write vmcs02/vmcs01 Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54806839.1080301@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.