From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers Date: Thu, 04 Dec 2014 06:51:49 -0800 Message-ID: <54807505.2000406@roeck-us.net> References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-9-git-send-email-linux@roeck-us.net> <54806F2A.7070107@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Russell King , Wim Van Sebroeck , Catalin Marinas , Maxime Ripard , Andrew Morton , "linux-samsung-soc@vger.kernel.org" , Linux Watchdog Mailing List , Arnd Bergmann , Linux PM list , Dmitry Eremin-Solenikov , Tomasz Figa , Randy Dunlap , Will Deacon , "linux-kernel@vger.kernel.org" , Steven Rostedt , Jonas Jensen , "linux-doc@vger.kernel.org" , David Woodhouse , Ingo Molnar , linux-arm-kernel@lists.infradead.o List-Id: linux-pm@vger.kernel.org On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > Hi G=C3=BCnther, > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck wr= ote: >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck = wrote: >>>> Implementing a restart handler in a module don't make sense >>>> as there would be no guarantee that the module is loaded when >>>> a restart is needed. Unexport arm_pm_restart to ensure that >>>> no one gets the idea to do it anyway. >>> >>> Why not? I was just going to do that, but I got greeted by: >> >> Because you should register a restart handler instead, like the othe= r >> drivers in the same directory now do. > > That's a different thing. "there would be no guarantee that the modul= e is > loaded when a restart is needed" is also valid for restart handlers..= =2E > Not really, because you are supposed to unregister the restart handler on unload. Sure, you can instead clear arm_pm_reastart and leave the sy= stem with no means to restart ... Guenter >>> ERROR: "arm_pm_restart" [drivers/power/reset/rmobile-reset.ko] unde= fined! >>> >>> So now we have to make sure all reset drivers for a zillion differe= nt >>> hardware devices are builtin, and can't be modular? >>> >> No. All those drivers need to do is to register a restart handler us= ing >> the API provided in the patch series. >> >> Ultimately all restart handlers should do that and arm_pm_restart sh= ould >> go away entirely. That was the point of the patch series. > > Good. That's what I'm doing right know ;-) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linu= x-m68k.org > > In personal conversations with technical people, I call myself a hack= er. But > when I'm talking to journalists I just say "programmer" or something = like that. > -- Linus Torvalds > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:34932 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932128AbaLDOxc (ORCPT ); Thu, 4 Dec 2014 09:53:32 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1XwXme-003WSk-EC for linux-watchdog@vger.kernel.org; Thu, 04 Dec 2014 14:53:32 +0000 Message-ID: <54807505.2000406@roeck-us.net> Date: Thu, 04 Dec 2014 06:51:49 -0800 From: Guenter Roeck MIME-Version: 1.0 To: Geert Uytterhoeven CC: Russell King , Wim Van Sebroeck , Catalin Marinas , Maxime Ripard , Andrew Morton , "linux-samsung-soc@vger.kernel.org" , Linux Watchdog Mailing List , Arnd Bergmann , Linux PM list , Dmitry Eremin-Solenikov , Tomasz Figa , Randy Dunlap , Will Deacon , "linux-kernel@vger.kernel.org" , Steven Rostedt , Jonas Jensen , "linux-doc@vger.kernel.org" , David Woodhouse , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" , Heiko Stuebner Subject: Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-9-git-send-email-linux@roeck-us.net> <54806F2A.7070107@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > Hi G=C3=BCnther, > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck wrot= e: >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck w= rote: >>>> Implementing a restart handler in a module don't make sense >>>> as there would be no guarantee that the module is loaded when >>>> a restart is needed. Unexport arm_pm_restart to ensure that >>>> no one gets the idea to do it anyway. >>> >>> Why not? I was just going to do that, but I got greeted by: >> >> Because you should register a restart handler instead, like the other >> drivers in the same directory now do. > > That's a different thing. "there would be no guarantee that the module = is > loaded when a restart is needed" is also valid for restart handlers... > Not really, because you are supposed to unregister the restart handler on unload. Sure, you can instead clear arm_pm_reastart and leave the syst= em with no means to restart ... Guenter >>> ERROR: "arm_pm_restart" [drivers/power/reset/rmobile-reset.ko] undefi= ned! >>> >>> So now we have to make sure all reset drivers for a zillion different >>> hardware devices are builtin, and can't be modular? >>> >> No. All those drivers need to do is to register a restart handler usin= g >> the API provided in the patch series. >> >> Ultimately all restart handlers should do that and arm_pm_restart shou= ld >> go away entirely. That was the point of the patch series. > > Good. That's what I'm doing right know ;-) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org > > In personal conversations with technical people, I call myself a hacker= . But > when I'm talking to journalists I just say "programmer" or something li= ke that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 04 Dec 2014 06:51:49 -0800 Subject: [PATCH v7 08/11] arm/arm64: Unexport restart handlers In-Reply-To: References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-9-git-send-email-linux@roeck-us.net> <54806F2A.7070107@roeck-us.net> Message-ID: <54807505.2000406@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > Hi G?nther, > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck wrote: >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck wrote: >>>> Implementing a restart handler in a module don't make sense >>>> as there would be no guarantee that the module is loaded when >>>> a restart is needed. Unexport arm_pm_restart to ensure that >>>> no one gets the idea to do it anyway. >>> >>> Why not? I was just going to do that, but I got greeted by: >> >> Because you should register a restart handler instead, like the other >> drivers in the same directory now do. > > That's a different thing. "there would be no guarantee that the module is > loaded when a restart is needed" is also valid for restart handlers... > Not really, because you are supposed to unregister the restart handler on unload. Sure, you can instead clear arm_pm_reastart and leave the system with no means to restart ... Guenter >>> ERROR: "arm_pm_restart" [drivers/power/reset/rmobile-reset.ko] undefined! >>> >>> So now we have to make sure all reset drivers for a zillion different >>> hardware devices are builtin, and can't be modular? >>> >> No. All those drivers need to do is to register a restart handler using >> the API provided in the patch series. >> >> Ultimately all restart handlers should do that and arm_pm_restart should >> go away entirely. That was the point of the patch series. > > Good. That's what I'm doing right know ;-) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932321AbaLDOw5 (ORCPT ); Thu, 4 Dec 2014 09:52:57 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:34841 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932142AbaLDOw4 (ORCPT ); Thu, 4 Dec 2014 09:52:56 -0500 Message-ID: <54807505.2000406@roeck-us.net> Date: Thu, 04 Dec 2014 06:51:49 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Russell King , Wim Van Sebroeck , Catalin Marinas , Maxime Ripard , Andrew Morton , "linux-samsung-soc@vger.kernel.org" , Linux Watchdog Mailing List , Arnd Bergmann , Linux PM list , Dmitry Eremin-Solenikov , Tomasz Figa , Randy Dunlap , Will Deacon , "linux-kernel@vger.kernel.org" , Steven Rostedt , Jonas Jensen , "linux-doc@vger.kernel.org" , David Woodhouse , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" , Heiko Stuebner Subject: Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-9-git-send-email-linux@roeck-us.net> <54806F2A.7070107@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A02020A.54807548.010D,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 8 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > Hi Günther, > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck wrote: >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck wrote: >>>> Implementing a restart handler in a module don't make sense >>>> as there would be no guarantee that the module is loaded when >>>> a restart is needed. Unexport arm_pm_restart to ensure that >>>> no one gets the idea to do it anyway. >>> >>> Why not? I was just going to do that, but I got greeted by: >> >> Because you should register a restart handler instead, like the other >> drivers in the same directory now do. > > That's a different thing. "there would be no guarantee that the module is > loaded when a restart is needed" is also valid for restart handlers... > Not really, because you are supposed to unregister the restart handler on unload. Sure, you can instead clear arm_pm_reastart and leave the system with no means to restart ... Guenter >>> ERROR: "arm_pm_restart" [drivers/power/reset/rmobile-reset.ko] undefined! >>> >>> So now we have to make sure all reset drivers for a zillion different >>> hardware devices are builtin, and can't be modular? >>> >> No. All those drivers need to do is to register a restart handler using >> the API provided in the patch series. >> >> Ultimately all restart handlers should do that and arm_pm_restart should >> go away entirely. That was the point of the patch series. > > Good. That's what I'm doing right know ;-) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >