On 12/4/2014 3:25 PM, Ville Syrjälä wrote: > On Thu, Dec 04, 2014 at 03:07:52PM +0000, Michel Thierry wrote: >> We already have it for chv, but was missing for bdw. >> >> Signed-off-by: Michel Thierry >> --- >> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c >> index 788e1b6..91ddcd1 100644 >> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c >> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c >> @@ -756,9 +756,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring) >> * workaround for for a possible hang in the unlikely event a TLB >> * invalidation occurs during a PSD flush. >> */ >> + /* WaHdcDisableFetchWhenMasked:bdw */ >> /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */ >> WA_SET_BIT_MASKED(HDC_CHICKEN0, >> HDC_FORCE_NON_COHERENT | >> + HDC_DONOT_FETCH_MEM_WHEN_MASKED | >> (IS_BDW_GT3(dev) ? HDC_FENCE_DEST_SLM_DISABLE : 0)); > Reviewed-by: Ville Syrjälä > > We also seem to miss the w/a name for the "force non-coherent" thing. > Can you add that as well? Sure, I'll add the missing _WaForceEnableNonCoherent:bdw_ label >> >> /* Wa4x4STCOptimizationDisable:bdw */ >> -- >> 2.1.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx