From: Daniel Borkmann <dborkman@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>,
"Theodore Ts'o" <tytso@mit.edu>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Where exactly will arch_fast_hash be used
Date: Thu, 04 Dec 2014 16:51:38 +0100 [thread overview]
Message-ID: <5480830A.8090803@redhat.com> (raw)
In-Reply-To: <20141204154708.GA22185@gondor.apana.org.au>
On 12/04/2014 04:47 PM, Herbert Xu wrote:
> On Thu, Dec 04, 2014 at 04:43:31PM +0100, Daniel Borkmann wrote:
>>
>> Hm, I thought the kernel doc on arch_fast_hash() in include/linux/hash.h
>> would give enough of a hint ...
>
> I think something more explicit like "do not use this in a hash
> table unless you know what you're doing" might be needed.
Ok, I'm fine with that, do you want to submit a patch on top of, or
after Hannes' improvements [1] got in? Thanks a lot, Herbert.
[1] http://patchwork.ozlabs.org/patch/417761/
next prev parent reply other threads:[~2014-12-04 15:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 8:11 Where exactly will arch_fast_hash be used Herbert Xu
2014-12-04 12:34 ` Hannes Frederic Sowa
2014-12-04 13:14 ` Daniel Borkmann
2014-12-04 15:26 ` Thomas Graf
2014-12-04 15:29 ` Herbert Xu
2014-12-04 15:39 ` Thomas Graf
2014-12-04 15:43 ` Daniel Borkmann
2014-12-04 15:47 ` Herbert Xu
2014-12-04 15:51 ` Daniel Borkmann [this message]
2014-12-04 15:56 ` David Laight
2014-12-04 16:10 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2014-12-07 5:20 George Spelvin
2014-12-07 9:28 ` Herbert Xu
2014-12-07 10:02 ` George Spelvin
2014-12-07 12:51 ` Herbert Xu
2014-12-07 13:23 ` George Spelvin
2014-12-07 14:06 ` Hannes Frederic Sowa
2014-12-07 21:33 ` George Spelvin
2014-12-08 11:25 ` Hannes Frederic Sowa
2014-12-08 16:19 ` George Spelvin
2014-12-08 16:32 ` Hannes Frederic Sowa
2014-12-09 14:24 ` Herbert Xu
2014-12-07 13:14 ` Hannes Frederic Sowa
2014-12-07 13:30 ` George Spelvin
2014-12-07 13:41 ` Hannes Frederic Sowa
2014-12-07 13:52 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5480830A.8090803@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.