From: Jean-Mickael Guerin <jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Bruce Richardson
<bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH 2/2] ixgbe: don't override mbuf buffer length
Date: Thu, 04 Dec 2014 18:11:41 +0100 [thread overview]
Message-ID: <548095CD.5080607@6wind.com> (raw)
In-Reply-To: <20141204165847.GA7732@bricha3-MOBL3>
>> Which makes me think, that we probably shouldn't overwrite buf_len by rxq->mbuf_initializer.
>>
> I believe that it is perfectly safe to do so. All buffers from a mempool are meant
> to be the same size, therefore reading the length of one buffer should tell you
> what size all buffers are. If we do hit a scenario where we do need to support
> variable size buffers from a single mempool, we can do that via the older unoptimized
> code paths, I think, since it's a definite edge case.
>
I agree, and there is a place to store some values unique for all mbufs
in a pool:
struct rte_pktmbuf_pool_private {
uint16_t mbuf_data_room_size; /**< Size of data space in each
mbuf.*/
};
We could add a new field mbuf_buf_len here, it looks definitely better
than new callbacks in rte_mempool.
What do you think?
next prev parent reply other threads:[~2014-12-04 17:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 14:26 [PATCH 0/2] ixgbe: bug fixes for RX vector mode Jean-Mickael Guerin
[not found] ` <1417703181-23093-1-git-send-email-jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-04 14:26 ` [PATCH 1/2] ixgbe: fix setup of mbuf initializer template Jean-Mickael Guerin
[not found] ` <1417703181-23093-2-git-send-email-jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-04 14:39 ` Bruce Richardson
2014-12-04 14:42 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCA09-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 15:15 ` Jean-Mickael Guerin
[not found] ` <54807A91.7050805-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-04 16:22 ` Ananyev, Konstantin
2014-12-05 22:07 ` Thomas Monjalon
2014-12-04 14:26 ` [PATCH 2/2] ixgbe: don't override mbuf buffer length Jean-Mickael Guerin
[not found] ` <1417703181-23093-3-git-send-email-jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-04 14:40 ` Bruce Richardson
2014-12-04 14:50 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCA29-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 15:15 ` Bruce Richardson
2014-12-04 15:29 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCA80-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 15:32 ` Bruce Richardson
2014-12-04 16:03 ` Jean-Mickael Guerin
2014-12-04 16:20 ` Ananyev, Konstantin
2014-12-04 15:48 ` Thomas Monjalon
2014-12-04 16:05 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCAE4-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 16:18 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCB11-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 16:57 ` Ananyev, Konstantin
2014-12-04 16:58 ` Bruce Richardson
2014-12-04 17:11 ` Jean-Mickael Guerin [this message]
[not found] ` <548095CD.5080607-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-04 17:19 ` Bruce Richardson
2014-12-04 17:17 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCB91-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-04 17:22 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548095CD.5080607@6wind.com \
--to=jean-mickael.guerin-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.