All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] spi: spi-fsl-spi: Return an error code in fsl_spi_do_one_msg()
Date: Thu, 04 Dec 2014 19:18:22 +0100	[thread overview]
Message-ID: <5480A56E.8050308@gmail.com> (raw)
In-Reply-To: <CAOMZO5Dfs=+UP=76gzG1LisoWAZaYALxmXg0N+evTVCkFhSs5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Am 04.12.2014 um 15:12 schrieb Fabio Estevam:
> On Thu, Dec 4, 2014 at 11:25 AM, Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Right, missed that. However the code was bogus before, the status = -EINVAL
>> didn't make sense as the value of variable status isn't used before the
>> return.
>> Therefore we can remove the "status = -EINVAL".
> 
> Yes, I noticed that as well.
> 
>> Shall I submit a patch or what would be your preferred approach?
> 
> Yes, may be it would be better if you could submit a fix for this as
> separate patch, after Mark applies this one, so that we avoid
> conflicts.
> 
OK, just submitted the fix as a separate patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-12-04 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 13:15 [PATCH] spi: spi-fsl-spi: Return an error code in fsl_spi_do_one_msg() Fabio Estevam
     [not found] ` <CAFSsGVv5=gJ2t-sWwTGqDcWaaYVU7o6VqZEL4mvxgohkkvBxmw@mail.gmail.com>
     [not found]   ` <CAFSsGVv5=gJ2t-sWwTGqDcWaaYVU7o6VqZEL4mvxgohkkvBxmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-04 14:12     ` Fabio Estevam
     [not found]       ` <CAOMZO5Dfs=+UP=76gzG1LisoWAZaYALxmXg0N+evTVCkFhSs5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-04 18:18         ` Heiner Kallweit [this message]
     [not found]           ` <5480A56E.8050308-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-04 18:52             ` Fabio Estevam
     [not found]               ` <CAOMZO5Ahv23kjBXvapL8gGxtHcrOiEwnSXOAFyQ8RPBiK6rwKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-04 19:29                 ` Heiner Kallweit
     [not found] ` <1417698947-4273-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-12-04 13:34   ` Heiner Kallweit
2014-12-04 22:44   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5480A56E.8050308@gmail.com \
    --to=hkallweit1-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.