All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: Remove support for legacy PM
Date: Thu, 04 Dec 2014 19:19:58 +0100	[thread overview]
Message-ID: <5480A5CE.3010802@metafoo.de> (raw)
In-Reply-To: <20141204181111.GD7944@katana>

On 12/04/2014 07:11 PM, Wolfram Sang wrote:
> On Sun, Nov 30, 2014 at 05:52:32PM +0100, Lars-Peter Clausen wrote:
>> There haven't been any I2C driver that use the legacy suspend/resume
>> callbacks for a while now and new drivers are supposed to use PM ops. So
>> remove support for legacy suspend/resume for I2C drivers.
>>
>> Since there aren't any special bus specific things to do during
>> suspend/resume and since the PM core will automatically fallback directly to
>> using the device's PM ops if no bus PM ops are specified there is no need to
>> have any I2C bus PM ops.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
> I'll keep this for 3.20, 3.19 is too close now. But thanks, the diffstat
> looks great :) Just curious, has buildbot tested this already?
>

No, but I did allyesconfig on both ARM and x86. As well as a `grep " 
i2c_driver "  -A20 * -r | grep '\(suspend\|resume\)'` and running the 
following cocci script.

@@
identifier fn;
identifier drv;
@@
struct i2c_driver drv  = {
     ...,
*   .suspend = fn,
     ...,
};

@@
identifier fn;
identifier drv;
@@
struct i2c_driver drv = {
     ...,
*   .resume = fn,
     ...,
};

None of those methods found anything, so I'm quite confident that there are 
no users left.

- Lars

  reply	other threads:[~2014-12-04 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 16:52 [PATCH 1/2] Documentation: i2c: Use PM ops instead of legacy suspend/resume Lars-Peter Clausen
     [not found] ` <1417366352-22356-1-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-11-30 16:52   ` [PATCH 2/2] i2c: Remove support for legacy PM Lars-Peter Clausen
2014-12-04 18:11     ` Wolfram Sang
2014-12-04 18:19       ` Lars-Peter Clausen [this message]
2014-12-04 18:23         ` Wolfram Sang
     [not found]     ` <1417366352-22356-2-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-12-22 19:10       ` Wolfram Sang
2014-12-04 18:09   ` [PATCH 1/2] Documentation: i2c: Use PM ops instead of legacy suspend/resume Wolfram Sang
2014-12-03 22:00 ` Jonathan Corbet
     [not found]   ` <20141203170022.6ec17a33-T1hC0tSOHrs@public.gmane.org>
2014-12-04  4:39     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5480A5CE.3010802@metafoo.de \
    --to=lars@metafoo.de \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.