* [PATCH 3/3] ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
@ 2014-12-03 23:06 ` vishnupatekar
0 siblings, 0 replies; 5+ messages in thread
From: vishnupatekar @ 2014-12-03 23:06 UTC (permalink / raw)
To: linux-arm-kernel
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++
arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index ed364d5..374897b 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,6 +112,16 @@
pinctrl-0 = <&uart0_pins_a>;
status = "okay";
};
+ ps20: ps2 at 0x01c2a000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&ps2_0_pins>;
+ status = "okay";
+ };
+ ps21: ps2 at 0x01c2a400 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&ps2_1_pins>;
+ status = "okay";
+ };
i2c0: i2c at 01c2ac00 {
pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 8605f2b..c77635d 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -357,7 +357,7 @@
usb_clk: clk at 01c200cc {
#clock-cells = <1>;
- #reset-cells = <1>;
+ #reset-cells = <1>;
compatible = "allwinner,sun4i-a10-usb-clk";
reg = <0x01c200cc 0x4>;
clocks = <&pll6 1>;
@@ -852,6 +852,19 @@
allwinner,drive = <0>;
allwinner,pull = <0>;
};
+ ps2_0_pins: ps2_0 at 0 {
+ allwinner,pins = "PI20","PI21";
+ allwinner,function = "ps2";
+ allwinner,drive = <0>;
+ allwinner,pull = <0>;
+ };
+ ps2_1_pins: ps2_1 at 0 {
+ allwinner,pins = "PH12","PH13";
+ allwinner,function = "ps2";
+ allwinner,drive = <0>;
+ allwinner,pull = <0>;
+ };
+
};
timer at 01c20c00 {
@@ -1079,5 +1092,20 @@
#interrupt-cells = <3>;
interrupts = <1 9 0xf04>;
};
+ ps20: ps2 at 0x01c2a000 {
+ compatible = "allwinner,sun7i-a20-ps2";
+ reg = <0x01c2a000 0x400>;
+ interrupts = <0 62 4>;
+ clocks = <&apb1_gates 6>;
+ status = "disabled";
+ };
+ ps21: ps2 at 0x01c2a400 {
+ compatible = "allwinner,sun7i-a20-ps2";
+ reg = <0x01c2a400 0x400>;
+ interrupts = <0 63 4>;
+ clocks = <&apb1_gates 7>;
+ status = "disabled";
+ };
+
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
@ 2014-12-03 23:06 ` vishnupatekar
0 siblings, 0 replies; 5+ messages in thread
From: vishnupatekar @ 2014-12-03 23:06 UTC (permalink / raw)
To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
inux-kernel-u79uwXL29TY76Z2rM5mHXA, vishnupatekar
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++
arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index ed364d5..374897b 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,6 +112,16 @@
pinctrl-0 = <&uart0_pins_a>;
status = "okay";
};
+ ps20: ps2@0x01c2a000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&ps2_0_pins>;
+ status = "okay";
+ };
+ ps21: ps2@0x01c2a400 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&ps2_1_pins>;
+ status = "okay";
+ };
i2c0: i2c@01c2ac00 {
pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 8605f2b..c77635d 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -357,7 +357,7 @@
usb_clk: clk@01c200cc {
#clock-cells = <1>;
- #reset-cells = <1>;
+ #reset-cells = <1>;
compatible = "allwinner,sun4i-a10-usb-clk";
reg = <0x01c200cc 0x4>;
clocks = <&pll6 1>;
@@ -852,6 +852,19 @@
allwinner,drive = <0>;
allwinner,pull = <0>;
};
+ ps2_0_pins: ps2_0@0 {
+ allwinner,pins = "PI20","PI21";
+ allwinner,function = "ps2";
+ allwinner,drive = <0>;
+ allwinner,pull = <0>;
+ };
+ ps2_1_pins: ps2_1@0 {
+ allwinner,pins = "PH12","PH13";
+ allwinner,function = "ps2";
+ allwinner,drive = <0>;
+ allwinner,pull = <0>;
+ };
+
};
timer@01c20c00 {
@@ -1079,5 +1092,20 @@
#interrupt-cells = <3>;
interrupts = <1 9 0xf04>;
};
+ ps20: ps2@0x01c2a000 {
+ compatible = "allwinner,sun7i-a20-ps2";
+ reg = <0x01c2a000 0x400>;
+ interrupts = <0 62 4>;
+ clocks = <&apb1_gates 6>;
+ status = "disabled";
+ };
+ ps21: ps2@0x01c2a400 {
+ compatible = "allwinner,sun7i-a20-ps2";
+ reg = <0x01c2a400 0x400>;
+ interrupts = <0 63 4>;
+ clocks = <&apb1_gates 7>;
+ status = "disabled";
+ };
+
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [linux-sunxi] [PATCH 3/3] ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
@ 2014-12-04 20:04 ` Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2014-12-04 20:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 12/04/2014 12:06 AM, vishnupatekar wrote:
> ---
> arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++
> arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++-
> 2 files changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> index ed364d5..374897b 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> @@ -112,6 +112,16 @@
> pinctrl-0 = <&uart0_pins_a>;
> status = "okay";
> };
> + ps20: ps2 at 0x01c2a000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ps2_0_pins>;
> + status = "okay";
> + };
> + ps21: ps2 at 0x01c2a400 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ps2_1_pins>;
> + status = "okay";
> + };
I don't think this should be enabled by default, since there
is no ps2 connector on the board, and the pins can be used
in a different manner too.
I do think it is useful to have it in there as an example for people who want to use
it, but commented out, please also add a comment stating that using ps20 conflicts
with using the hdmi connector.
Regards,
Hans
>
> i2c0: i2c at 01c2ac00 {
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 8605f2b..c77635d 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -357,7 +357,7 @@
>
> usb_clk: clk at 01c200cc {
> #clock-cells = <1>;
> - #reset-cells = <1>;
> + #reset-cells = <1>;
> compatible = "allwinner,sun4i-a10-usb-clk";
> reg = <0x01c200cc 0x4>;
> clocks = <&pll6 1>;
> @@ -852,6 +852,19 @@
> allwinner,drive = <0>;
> allwinner,pull = <0>;
> };
> + ps2_0_pins: ps2_0 at 0 {
> + allwinner,pins = "PI20","PI21";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> + ps2_1_pins: ps2_1 at 0 {
> + allwinner,pins = "PH12","PH13";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> };
>
> timer at 01c20c00 {
> @@ -1079,5 +1092,20 @@
> #interrupt-cells = <3>;
> interrupts = <1 9 0xf04>;
> };
> + ps20: ps2 at 0x01c2a000 {
> + compatible = "allwinner,sun7i-a20-ps2";
> + reg = <0x01c2a000 0x400>;
> + interrupts = <0 62 4>;
> + clocks = <&apb1_gates 6>;
> + status = "disabled";
> + };
> + ps21: ps2 at 0x01c2a400 {
> + compatible = "allwinner,sun7i-a20-ps2";
> + reg = <0x01c2a400 0x400>;
> + interrupts = <0 63 4>;
> + clocks = <&apb1_gates 7>;
> + status = "disabled";
> + };
> +
> };
> };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
@ 2014-12-04 20:04 ` Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2014-12-04 20:04 UTC (permalink / raw)
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
inux-kernel-u79uwXL29TY76Z2rM5mHXA, vishnupatekar
Hi,
On 12/04/2014 12:06 AM, vishnupatekar wrote:
> ---
> arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++
> arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++-
> 2 files changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> index ed364d5..374897b 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> @@ -112,6 +112,16 @@
> pinctrl-0 = <&uart0_pins_a>;
> status = "okay";
> };
> + ps20: ps2@0x01c2a000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ps2_0_pins>;
> + status = "okay";
> + };
> + ps21: ps2@0x01c2a400 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ps2_1_pins>;
> + status = "okay";
> + };
I don't think this should be enabled by default, since there
is no ps2 connector on the board, and the pins can be used
in a different manner too.
I do think it is useful to have it in there as an example for people who want to use
it, but commented out, please also add a comment stating that using ps20 conflicts
with using the hdmi connector.
Regards,
Hans
>
> i2c0: i2c@01c2ac00 {
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 8605f2b..c77635d 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -357,7 +357,7 @@
>
> usb_clk: clk@01c200cc {
> #clock-cells = <1>;
> - #reset-cells = <1>;
> + #reset-cells = <1>;
> compatible = "allwinner,sun4i-a10-usb-clk";
> reg = <0x01c200cc 0x4>;
> clocks = <&pll6 1>;
> @@ -852,6 +852,19 @@
> allwinner,drive = <0>;
> allwinner,pull = <0>;
> };
> + ps2_0_pins: ps2_0@0 {
> + allwinner,pins = "PI20","PI21";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> + ps2_1_pins: ps2_1@0 {
> + allwinner,pins = "PH12","PH13";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> };
>
> timer@01c20c00 {
> @@ -1079,5 +1092,20 @@
> #interrupt-cells = <3>;
> interrupts = <1 9 0xf04>;
> };
> + ps20: ps2@0x01c2a000 {
> + compatible = "allwinner,sun7i-a20-ps2";
> + reg = <0x01c2a000 0x400>;
> + interrupts = <0 62 4>;
> + clocks = <&apb1_gates 6>;
> + status = "disabled";
> + };
> + ps21: ps2@0x01c2a400 {
> + compatible = "allwinner,sun7i-a20-ps2";
> + reg = <0x01c2a400 0x400>;
> + interrupts = <0 63 4>;
> + clocks = <&apb1_gates 7>;
> + status = "disabled";
> + };
> +
> };
> };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
[not found] ` <5480BE43.9050308-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2014-12-05 8:53 ` Vishnu Patekar
0 siblings, 0 replies; 5+ messages in thread
From: Vishnu Patekar @ 2014-12-05 8:53 UTC (permalink / raw)
To: Hans de Goede
Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, Kumar Gala,
linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
inux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 4594 bytes --]
On Fri, Dec 5, 2014 at 1:34 AM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Hi,
>
> On 12/04/2014 12:06 AM, vishnupatekar wrote:
>
>> ---
>> arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++
>> arch/arm/boot/dts/sun7i-a20.dtsi | 30
>> ++++++++++++++++++++++-
>> 2 files changed, 39 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
>> b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
>> index ed364d5..374897b 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
>> @@ -112,6 +112,16 @@
>> pinctrl-0 = <&uart0_pins_a>;
>> status = "okay";
>> };
>> + ps20: ps2@0x01c2a000 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&ps2_0_pins>;
>> + status = "okay";
>> + };
>> + ps21: ps2@0x01c2a400 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&ps2_1_pins>;
>> + status = "okay";
>> + };
>>
>
> I don't think this should be enabled by default, since there
> is no ps2 connector on the board, and the pins can be used
> in a different manner too.
>
I do think it is useful to have it in there as an example for people who
> want to use
> it, but commented out, please also add a comment stating that using ps20
> conflicts
> with using the hdmi connector.
>
> Okie, For lime2 board dts file, I'll comment out these ps20 and ps21 nodes
stating that In case uncommented this will confilt with hdmi connector.
This also will be included in next patch version.
> Regards,
>
> Hans
>
>
>
>> i2c0: i2c@01c2ac00 {
>> pinctrl-names = "default";
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
>> b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index 8605f2b..c77635d 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -357,7 +357,7 @@
>>
>> usb_clk: clk@01c200cc {
>> #clock-cells = <1>;
>> - #reset-cells = <1>;
>> + #reset-cells = <1>;
>> compatible = "allwinner,sun4i-a10-usb-clk";
>> reg = <0x01c200cc 0x4>;
>> clocks = <&pll6 1>;
>> @@ -852,6 +852,19 @@
>> allwinner,drive = <0>;
>> allwinner,pull = <0>;
>> };
>> + ps2_0_pins: ps2_0@0 {
>> + allwinner,pins = "PI20","PI21";
>> + allwinner,function = "ps2";
>> + allwinner,drive = <0>;
>> + allwinner,pull = <0>;
>> + };
>> + ps2_1_pins: ps2_1@0 {
>> + allwinner,pins = "PH12","PH13";
>> + allwinner,function = "ps2";
>> + allwinner,drive = <0>;
>> + allwinner,pull = <0>;
>> + };
>> +
>> };
>>
>> timer@01c20c00 {
>> @@ -1079,5 +1092,20 @@
>> #interrupt-cells = <3>;
>> interrupts = <1 9 0xf04>;
>> };
>> + ps20: ps2@0x01c2a000 {
>> + compatible = "allwinner,sun7i-a20-ps2";
>> + reg = <0x01c2a000 0x400>;
>> + interrupts = <0 62 4>;
>> + clocks = <&apb1_gates 6>;
>> + status = "disabled";
>> + };
>> + ps21: ps2@0x01c2a400 {
>> + compatible = "allwinner,sun7i-a20-ps2";
>> + reg = <0x01c2a400 0x400>;
>> + interrupts = <0 63 4>;
>> + clocks = <&apb1_gates 7>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>>
>>
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: Type: text/html, Size: 7181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-05 8:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 23:06 [PATCH 3/3] ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts vishnupatekar
2014-12-03 23:06 ` vishnupatekar
2014-12-04 20:04 ` [linux-sunxi] " Hans de Goede
2014-12-04 20:04 ` Hans de Goede
[not found] ` <5480BE43.9050308-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-05 8:53 ` Vishnu Patekar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.