All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] btrfs-progs:fsck: Recover btree with some corrupted leaf/node.
Date: Fri, 5 Dec 2014 08:26:05 +0800	[thread overview]
Message-ID: <5480FB9D.7030708@cn.fujitsu.com> (raw)
In-Reply-To: <5480FACB.7090601@cn.fujitsu.com>


-------- Original Message --------
Subject: Re: [PATCH 2/3] btrfs-progs:fsck: Recover btree with some 
corrupted leaf/node.
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Date: 2014年12月05日 08:22
>
> -------- Original Message --------
> Subject: Re: [PATCH 2/3] btrfs-progs:fsck: Recover btree with some 
> corrupted leaf/node.
> From: David Sterba <dsterba@suse.cz>
> To: Qu Wenruo <quwenruo@cn.fujitsu.com>
> Date: 2014年12月05日 01:35
>> On Thu, Dec 04, 2014 at 10:52:44AM +0800, Qu Wenruo wrote:
>>> +    trans = btrfs_start_transaction(root, -1);
>> What does '-1' mean here? I've never seen this before, just curious.
> I'am not completely sure, but when deleting item, num_blocks will be 
> minus or still 1?
>
> Thanks,
> Qu
Oh, no, I got it confused with btrfs_search_slot...
start_transcation should only accept positive value.

I'll update the patch with your other comment.

Sorry for the mistake.

Thanks for your reviewing.
Qu

  reply	other threads:[~2014-12-05  0:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:52 [PATCH 0/3] Add repair function for btree and missing inode Qu Wenruo
2014-12-04  2:52 ` [PATCH 1/3] btrfs-progs: record and report leaf/node corruption in fs/subvol tree Qu Wenruo
2014-12-04  2:52 ` [PATCH 2/3] btrfs-progs:fsck: Recover btree with some corrupted leaf/node Qu Wenruo
2014-12-04 17:35   ` David Sterba
2014-12-05  0:22     ` Qu Wenruo
2014-12-05  0:26       ` Qu Wenruo [this message]
2014-12-04  2:52 ` [PATCH 3/3] btrfs-progs: Add inode item rebuild function Qu Wenruo
2014-12-04 17:41   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5480FB9D.7030708@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.