All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jianhua Xie <jianhua.xie@freescale.com>
To: <roopa@cumulusnetworks.com>, <jiri@resnulli.us>,
	<sfeldma@gmail.com>, <jhs@mojatatu.com>, <bcrl@kvack.org>,
	<tgraf@suug.ch>, <john.fastabend@gmail.com>,
	<stephen@networkplumber.org>, <linville@tuxdriver.com>,
	<nhorman@tuxdriver.com>, <nicolas.dichtel@6wind.com>,
	<vyasevic@redhat.com>, <f.fainelli@gmail.com>,
	<buytenh@wantstofly.org>, <aviadr@mellanox.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<shm@cumulusnetworks.com>, <gospo@cumulusnetworks.com>,
	jianhua Xie <jianhua.xie@freescale.com>
Subject: Re: [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD
Date: Fri, 5 Dec 2014 11:25:16 +0800	[thread overview]
Message-ID: <5481259C.3040707@freescale.com> (raw)
In-Reply-To: <1417746401-8140-4-git-send-email-roopa@cumulusnetworks.com>


在 2014年12月05日 10:26, roopa@cumulusnetworks.com 写道:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> This patch just sets the feature flag on rocker ports
> ---
>   drivers/net/ethernet/rocker/rocker.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
> index fded127..3fe19b0 100644
> --- a/drivers/net/ethernet/rocker/rocker.c
> +++ b/drivers/net/ethernet/rocker/rocker.c
> @@ -4003,7 +4003,8 @@ static int rocker_probe_port(struct rocker *rocker, unsigned int port_number)
>   		       NAPI_POLL_WEIGHT);
>   	rocker_carrier_init(rocker_port);
>   
> -	dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
> +	dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER |
> +					 NETIF_F_HW_SWITCH_OFFLOAD;
Do you have a plan on enabling/disabling  this flag dynamically by ethtool?

Thanks & B.R
Jianhua
>   
>   	err = register_netdev(dev);
>   	if (err) {

  reply	other threads:[~2014-12-05  3:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05  2:26 [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD roopa
2014-12-05  3:25 ` Jianhua Xie [this message]
2014-12-05  4:14   ` Roopa Prabhu
2014-12-05  4:44     ` Jianhua Xie
2014-12-05  6:16   ` Scott Feldman
2014-12-05  6:38     ` John Fastabend
2014-12-05 13:18 ` Sergei Shtylyov
2014-12-05 14:04   ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5481259C.3040707@freescale.com \
    --to=jianhua.xie@freescale.com \
    --cc=aviadr@mellanox.com \
    --cc=bcrl@kvack.org \
    --cc=buytenh@wantstofly.org \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    --cc=shm@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=tgraf@suug.ch \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.