From: Julien Grall <julien.grall@linaro.org>
To: Vijay Kilari <vijay.kilari@gmail.com>, Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: xen/arm: uart interrupts handling
Date: Fri, 05 Dec 2014 10:52:06 +0000 [thread overview]
Message-ID: <54818E56.4030304@linaro.org> (raw)
In-Reply-To: <CALicx6vVSL3mCxO6jrn2C-O8cFXLiPX=-uPPirB_JW02Bgx4zQ@mail.gmail.com>
Hi Vijay,
On 05/12/2014 00:46, Vijay Kilari wrote:
> Yes, this is the behaviour that Iam seeing. In Linux, uart driver
> masks TXI interrupt
> in IMSC if buffer is empty. However in xen, this scenario is not
> handled. This is the reason why cpu does not come out of uart irq
> routine if TX interrupt is raised but buffer is empty.
>
> I have added below changes to fix this on top of your suggested change
Can you send a formal patch (commit message + signed-off-by)?
Also, you will have to make sure you don't break the other serial drivers.
Regards,
--
Julien Grall
prev parent reply other threads:[~2014-12-05 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 3:50 xen/arm: uart interrupts handling Vijay Kilari
2014-12-04 13:51 ` Julien Grall
2014-12-04 15:40 ` Tim Deegan
2014-12-05 0:46 ` Vijay Kilari
2014-12-05 10:52 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54818E56.4030304@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.