From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: xen/arm: uart interrupts handling
Date: Fri, 05 Dec 2014 10:52:06 +0000
Message-ID: <54818E56.4030304@linaro.org>
References: <CALicx6trd6Pvsit0LfbC66JU5G3r+1XTt0d-h0DLo8rd31X9vw@mail.gmail.com>	<548066FE.90905@linaro.org>	<20141204154006.GA43178@deinos.phlegethon.org>
	<CALicx6vVSL3mCxO6jrn2C-O8cFXLiPX=-uPPirB_JW02Bgx4zQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6vVSL3mCxO6jrn2C-O8cFXLiPX=-uPPirB_JW02Bgx4zQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>, Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 05/12/2014 00:46, Vijay Kilari wrote:
  > Yes, this is the behaviour that Iam seeing. In Linux, uart driver
> masks TXI interrupt
> in IMSC if buffer is empty. However in xen, this scenario is not
> handled. This is the reason why cpu does not come out of uart irq
> routine if TX interrupt is raised but buffer is empty.
>
> I have added below changes to fix this on top of your suggested change

Can you send a formal patch (commit message + signed-off-by)?

Also, you will have to make sure you don't break the other serial drivers.

Regards,

-- 
Julien Grall