Re: [PATCH v6 0/4] Initial support for ImgTec PWM DAC and PDM DAC

[Ezequiel Garcia <ezequiel.garcia@imgtec.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 2206 bytes --]

Hi Thierry,

On 11/28/2014 03:12 PM, Naidu Tellapati wrote:
> The Pistachio SOC from Imagination Technologies includes – 4x PDM blocks
> and 1x “basic PWM” block with four output channels. These share 4 MFIO pins,
> each PWM channel being muxed with each PDM block output (0-3 muxed with 0-3)
> using the CR_PERIP_PWM_PDM_CONTROL register in the peripheral wrapper
> register bank (offset 0x140). The PDM and PWM outputs are used to control
> targets such as LCD backlight.
> 
> The PWM driver uses Linux PWM framework. Since the PDM does not fit into PWM
> framework we have implemented it as a MISC driver.
> 
> The series is based on v3.18-rc5.
> 
> Changes from v5:
> 
>  * Used syscon for accessing PWM & PDM control register.
> 
> Changes from v4:
> 
>  * Removed CR_prefix from the defined macros.
> 
>  * Folded same data type varibles in one line.
> 
>  * Removed cr-periph property from PWM DT binding document.
> 
>  * Removed regmap_update_bits from img_pwm_enable and img_pwm_disable functions.
> 
>  * Addressed few more comments given in v4.
> 
> Changes from v3:
> 
>  * Addressed couple of comments given in v3.
> 
> Changes from v2:
> 
>  * Added depends on MIPS || COMPILE_TEST.
> 
>  * Corrected the logic while calculating time base steps.
> 
>  * Addressed few other minor comments given in v2.
> 
> Changes from v1:
> 
>  * Used regmap_update_bits at some places in the driver.
> 
>  * Placed some #defines next to their register.
> 
>  * Added depends on HAS_IOMEM in Kconfig.
> 
>  * Removed unnecessary paragraph from file header.
> 
>  * Defined register masks in a readable way.
> 
>  * Renamed clk-names with clock-names.
> 
>  * Added system interface clock in DT binding document.
> 
>  * Addressed few other minor review comments given in v1.
> 
> Naidu Tellapati (4):
>   pwm: Imagination Technologies PWM DAC driver
>   DT: pwm: Add binding document for IMG PWM DAC
>   pdm: Imagination Technologies PDM DAC driver
>   DT: pdm: Add binding document for IMG PDM DAC
> 

Any comments on this series? I was aiming at merging this for v3.19,
hope it's not too late already!

Thanks,
-- 
Ezequiel