From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 5388DE008FF; Fri, 5 Dec 2014 06:24:11 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, WEIRD_PORT autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.170 listed in list.dnswl.org] * 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D86DCE008A7 for ; Fri, 5 Dec 2014 06:24:08 -0800 (PST) Received: by mail-wi0-f170.google.com with SMTP id bs8so1555935wib.3 for ; Fri, 05 Dec 2014 06:24:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=V8cEXLifWVT5KWrvpNsa0TqadVMPR8tXIh3CAPkMsYs=; b=mN5v/KidpJauJdGWCtKP2sc7eZQH79GZHIoIZqRPqPb/lxxQzfPkq0GjBqBKQS3Hos YT83O81u4Tpa/270ChOqtRMmNjj1w5QQaczmb/L4L0vEzNdjL4XaJjrfY8YmSUTuDdEi rnl6yn0Zdf8AJK5vipDhloMhBSzigyHI+pZ3+EbMcjQxuTpxmX1m9o2Ne3CD+RVGrcXO s71QQw07/NidarvEQtBzoSHDWwGEbso3ZhCn2s2G7F8Jhbv4Ft02X8cZmzQ4W+NE4JQZ yi7eC8Uztnr7caWHZXTZwH35wh4Hs/nSLYgkIQ1ynzEnRduNKiUj+QHhXWS6/qfUt1uj gZhw== X-Gm-Message-State: ALoCoQns9QdLBXhJNvCqsuzNX10rNwHEuEZZJyV3s/87OizvICfTwAY//7YwiiqH8e29atZVxBHe X-Received: by 10.194.161.202 with SMTP id xu10mr25030329wjb.4.1417789447366; Fri, 05 Dec 2014 06:24:07 -0800 (PST) Received: from [192.168.2.84] ([83.217.123.106]) by mx.google.com with ESMTPSA id hn2sm45100512wjc.5.2014.12.05.06.24.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 06:24:06 -0800 (PST) Message-ID: <5481C006.7030805@intel.com> Date: Fri, 05 Dec 2014 14:24:06 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "Damian, Alexandru" References: <5478DBF2.8050802@intel.com> <5480921E.10602@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] michaelw/toaster/import-layers X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 14:24:11 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 05/12/14 14:01, Barros Pena, Belen wrote: > On 04/12/2014 16:55, "Michael Wood" wrote: > >> New review request: updated functionality (pushed to same branch >> poky-contrib michaelw/toaster/import-layers) > This is looking really good from the UI side. I only found a couple of > small things that I could fix myself. I've pushed them to > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/impo > rt-layers2 > > Michael: could you review and merge them to your branch if they are ok? Great thanks. > There is just one more issue: the content of the notifications shown in > the project page when you import a layer. I am really keeping an eye in > all our notifications to make sure their content has a certain > consistency. When you add layers to a project we include in the > notifications: > > 1. The total number of layers added to the project > 2. The names of each of the layers added, with the names being links to > the corresponding layer details pages > > Currently, the notifications when you import and add a single layer are > missing number 1 above: the name of the layer is not a link. The > notifications when you import a layer but add several of them due to > dependencies are missing both 1 and 2 above. > > The notifications when you import a layer should look exactly like in the > attached document. Is there any chance we could get those notifications > changed? Ah yes, I was going to mention that, currently this data would all have to be passed in using the URL e.g. the url you would be redirected to would be like http://127.0.0.1:8000/toastergui/project/3/#/layerimported=intel-arduino,deps=meta-imported,meta-efl,meta-intel,meta-multimedia,meta-oe,meta-ruby etc… then that string would need to be parsed into the right parts for the error message. However thinking about it again it should be possible to use the session cookie to do this. I'll investigate. > Thanks! > > Belén > > >> Thanks, >> >> Michael >> >> On 01/12/14 14:27, Damian, Alexandru wrote: >>> Since we're rolling this back, just a note on adding layerversions - >>> >>> For all imported layerversion, the project field MUST be set to >>> current project - otherwise branches with a name different from >>> project release name won't show up in the current project. >>> >>> On Mon, Dec 1, 2014 at 11:27 AM, Damian, Alexandru >>> > wrote: >>> >>> Thank you, taken for submission ! >>> >>> On Fri, Nov 28, 2014 at 8:32 PM, Michael Wood >>> > wrote: >>> >>> poky-contrib michaelw/toaster/import-layers >>> >>> bitbake: toaster: Add import layer feature >>> bitbake: toaster: libtoaster Add editProject and >>> getLayerDepsForProject >>> bitbake: toaster: libtoaster Add a error handler to GET in >>> makeTypehead >>> >>> Thanks, >>> >>> Michael >>> -- >>> _______________________________________________ >>> toaster mailing list >>> toaster@yoctoproject.org >>> https://lists.yoctoproject.org/listinfo/toaster >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> SSG / OTC >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> SSG / OTC >>> >>> --------------------------------------------------------------------- >>> Intel Corporation (UK) Limited >>> Registered No. 1134945 (England) >>> Registered Office: Pipers Way, Swindon SN3 1RJ >>> VAT No: 860 2173 47 >>> >>> This e-mail and any attachments may contain confidential material for >>> the sole use of the intended recipient(s). Any review or distribution >>> by others is strictly prohibited. If you are not the intended >>> recipient, please contact the sender and delete all copies. >>> >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster