From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Date: Sat, 06 Dec 2014 00:31:46 +0800 Message-ID: <5481DDF2.6010700@rock-chips.com> References: <1417760564-16858-1-git-send-email-andy.yan@rock-chips.com> <1417787724.3227.10.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417787724.3227.10.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKT24gMjAxNOW5tDEy5pyIMDXml6UgMjE6NTUsIFBoaWxpcHAgWmFiZWwgd3Jv dGU6Cj4gSGkgQW5keSwKPgo+IEFtIEZyZWl0YWcsIGRlbiAwNS4xMi4yMDE0LCAxNDoyMiArMDgw MCBzY2hyaWViIEFuZHkgWWFuOgo+PiBXZSBmb3VuZCBGcmVlc2NhbGUgaW14NiBhbmQgUm9ja2No aXAgcmszMjg4IGFuZCBJbmdlbmljIEpaNDc4MCAoWGJ1cnN0L01JUFMpCj4+IHVzZSB0aGUgaW50 ZXJmYWNlIGNvbXBhdGlibGUgRGVzaWdud2FyZSBIRE1JIElQLCBidXQgdGhleSBhbHNvIGhhdmUg c29tZQo+PiBsaWdodGx5IGRpZmZlcmVuY2VzLCBzdWNoIGFzIHBoeSBwbGwgY29uZmlndXJhdGlv biwgcmVnaXN0ZXIgd2lkdGgoaW14IGhkbWkKPj4gcmVnaXN0ZXIgaXMgb25lIGJ5dGUsIGJ1dCBy azMyODggaXMgNCBieXRlcyB3aWR0aCBhbmQgY2FuIG9ubHkgYmUgYWNjZXNzZWQKPj4gYnkgd29y ZCksIDRLIHN1cHBvcnQoaW14NiBkb2Vzbid0IHN1cHBvcnQgNGssIGJ1dCByazMyODggZG9lcyks IGFuZCBIRE1JMi4wCj4+IHN1cHBvcnQuCj4+Cj4+IFRvIHJldXNlIHRoZSBpbXgtaGRtaSBkcml2 ZXIsIHdlIG1ha2UgdGhpcyBwYXRjaCBzZXQ6Cj4+ICgxKTogZml4IHNvbWUgQ29kaW5nU3R5bGUg d2FybmluZyB0byBtYWtlIGNoZWNrcGF0Y2ggaGFwcHkKPj4gKDIpOiBjb252ZXJ0IGlteC1oZG1p IHRvIGRybV9icmlkZ2UKPj4gKDMpOiBzcGxpdCBwbGF0Zm9ybSBzcGVjaWZpYyBjb2RlCj4+ICg0 KTogbW92ZSBpbXgtaGRtaSB0byBicmlkZ2UvZHdfaGRtaQo+PiAoNSk6IGV4dGVuZCBkd19oZG1p LmMgdG8gc3VwcG9ydCByazMyODggaGRtaQo+PiAoNik6IGFkZCByb2NrY2hpcCByazMyODggcGxh dGZvcm0gc3BlY2lmaWMgY29kZSBkd19oZG1pLXJvY2tjaGlwLmMKPj4KPj4gQ2hhbmdlcyBpbiB2 MTg6Cj4+IC0gcmVtb3ZlIGEgbXVsdGlwbGUgYmxhbmsgbGluZXMgaW4gaW14LWhkbWkuYwo+PiAt IGZpeCBhIGNoZWNrcGF0Y2ggd2FybmluZyBpbiBpbXgtaGRtaV9wbHRmbS5jCj4+IC0gYWRkIHBv cnQgYmluZGluZ3MKPj4gLSBjb3JyZWN0IHNvbWUgc3BlbGxpbmcgbWlzdGFrZXMgaW4gZHdfaGRt aSBiaW5kaW5ncyBkb2MKPj4gLSBjb3JyZWN0IHNvbWUgc3BlbGxpbmcgbWlzdGFrZXMgaW4gZHdf aGRtaS1yb2NrY2hpcCBiaW5kaW5ncyBkb2MKPiBbLi4uXQo+Cj4gSSBhbSBoYXBweSB3aXRoIHRo ZSBzZXJpZXMgc28gZmFyLiBQZW5kaW5nIEFja3MgZnJvbSB0aGUgZGV2aWNlIHRyZWUKPiBtYWlu dGFpbmVycyBmb3IgdGhlIG5ldyBiaW5kaW5nIGRvY3VtZW50cywgSSdkIGxpa2UgdG8gYXBwbHkg ZWl0aGVyIHRoZQo+IHdob2xlIG9mIGl0IG9uIHRvcCBvZgo+ICAgICAgZ2l0Oi8vZ2l0LnBlbmd1 dHJvbml4LmRlL2dpdC9wemEvbGludXguZ2l0IGlteC1kcm0vbmV4dAo+IG9yIHRha2UgYXQgbGVh c3QgdGhlIGkuTVggc3BlY2lmaWMgcGF0Y2hlcyAoMS01KSBiZWNhdXNlIG9mIHRoZQo+IGRlcGVu ZGVuY3kgb24gdGhlIGlteC1kcm0gT0YgaGVscGVyIGNvbnZlcnNpb24uCj4KPiByZWdhcmRzCj4g UGhpbGlwcAo+Cj4KPgo+CiAgSSBhbSB2ZXJ5IGdsYWQgdG8gc2VlIHlvdSBhcmUgaGFwcHkgd2l0 aCB0aGUgcGF0Y2ggc2V0LCBpdCdzIHdvdWxkIGJlIAp2ZXJ5CiAgbmljZSBpZiB5b3UgY2FuIGFw cGx5IGFsbCBvZiBpdC4KICBUaGFua3MgdmVyeSBtdWNoIGZvciB5b3UgcmV2aWV3LgoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcg bGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhk cml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbaLEQcF (ORCPT ); Fri, 5 Dec 2014 11:32:05 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:40825 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbaLEQcE (ORCPT ); Fri, 5 Dec 2014 11:32:04 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: vladimir_zapolskiy@mentor.com X-SENDER-IP: 210.21.233.66 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5481DDF2.6010700@rock-chips.com> Date: Sat, 06 Dec 2014 00:31:46 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Philipp Zabel CC: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk, Greg Kroah-Hartman , Grant Likely , Rob Herring , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , Ian Campbell , Kumar Gala , vladimir_zapolskiy@mentor.com Subject: Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi References: <1417760564-16858-1-git-send-email-andy.yan@rock-chips.com> <1417787724.3227.10.camel@pengutronix.de> In-Reply-To: <1417787724.3227.10.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年12月05日 21:55, Philipp Zabel wrote: > Hi Andy, > > Am Freitag, den 05.12.2014, 14:22 +0800 schrieb Andy Yan: >> We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) >> use the interface compatible Designware HDMI IP, but they also have some >> lightly differences, such as phy pll configuration, register width(imx hdmi >> register is one byte, but rk3288 is 4 bytes width and can only be accessed >> by word), 4K support(imx6 doesn't support 4k, but rk3288 does), and HDMI2.0 >> support. >> >> To reuse the imx-hdmi driver, we make this patch set: >> (1): fix some CodingStyle warning to make checkpatch happy >> (2): convert imx-hdmi to drm_bridge >> (3): split platform specific code >> (4): move imx-hdmi to bridge/dw_hdmi >> (5): extend dw_hdmi.c to support rk3288 hdmi >> (6): add rockchip rk3288 platform specific code dw_hdmi-rockchip.c >> >> Changes in v18: >> - remove a multiple blank lines in imx-hdmi.c >> - fix a checkpatch warning in imx-hdmi_pltfm.c >> - add port bindings >> - correct some spelling mistakes in dw_hdmi bindings doc >> - correct some spelling mistakes in dw_hdmi-rockchip bindings doc > [...] > > I am happy with the series so far. Pending Acks from the device tree > maintainers for the new binding documents, I'd like to apply either the > whole of it on top of > git://git.pengutronix.de/git/pza/linux.git imx-drm/next > or take at least the i.MX specific patches (1-5) because of the > dependency on the imx-drm OF helper conversion. > > regards > Philipp > > > > I am very glad to see you are happy with the patch set, it's would be very nice if you can apply all of it. Thanks very much for you review.