From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7] net/phy: Add support for CS4315/CS4340 PHY
Date: Fri, 5 Dec 2014 08:49:59 -0800 [thread overview]
Message-ID: <5481E237.5030900@freescale.com> (raw)
In-Reply-To: <CANr=Z=Yu1ZGnQ-qpu+mmcx0FOD3WOiXZT=TvKytUh_jBqooh6Q@mail.gmail.com>
On 12/05/2014 08:29 AM, Joe Hershberger wrote:
> Hi York,
>
> On Fri, Dec 5, 2014 at 10:27 AM, York Sun <yorksun@freescale.com
> <mailto:yorksun@freescale.com>> wrote:
>>
>> On 11/10/2014 02:32 AM, Shengzhou Liu wrote:
>> > Add support for Cortina CS4315/CS4340 10G PHY.
>> > - This driver loads CS43xx firmware from NOR/NAND/SPI/SD device
>> > to initialize Cortina PHY.
>> > - Cortina PHY has non-standard offset of PHY ID registers, thus
>> > we define own get_phy_id() to override default get_phy_id().
>> > - To define macro CONFIG_PHY_CORTINA will enable this driver.
>> >
>> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com
> <mailto:Shengzhou.Liu@freescale.com>>
>> > ---
>> > v7: reorder it in alphabetical order in Makefile
>> > v6: polish it in phy.c and phy.h in alphabetical order
>> > v5: fix unclaimed variable in case of nand boot.
>> > v4: add support for loading cortina phy ucode from NAND/SPI/SD
>> > v3: move devad as '0' in cortina.c instead of in phy.c
>> > v2: no change.
>> >
>> Applied to u-boot-mpc85xx, awaiting upstream.
>
> Were my concerns from Nov 25 addressed?
>
No. Somehow I missed your comment. My apology.
Shengzhou, please follow up and address the comments. Please send additional
patch if needed.
York
prev parent reply other threads:[~2014-12-05 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 10:32 [U-Boot] [PATCH v7] net/phy: Add support for CS4315/CS4340 PHY Shengzhou Liu
2014-11-10 11:32 ` Shengzhou.Liu at freescale.com
2014-11-25 21:55 ` York Sun
2014-11-25 22:33 ` Joe Hershberger
2014-12-05 16:29 ` York Sun
2014-12-05 16:27 ` York Sun
2014-12-05 16:29 ` Joe Hershberger
2014-12-05 16:49 ` York Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5481E237.5030900@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.