Re: [PATCH iproute2 REGRESSIONS v2] ss: Fix layout/output issues introduced by regression

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 12/05/2014 08:06 PM, vadim4j@gmail.com wrote:

>   [...]
>>> @@ -2912,11 +2910,12 @@ static void netlink_show_one(struct filter *f,
>>>   		printf("%-*s ", state_width, "UNCONN");
>>>   	printf("%-6d %-6d ", rq, wq);
>>>
>>> -	if (resolve_services)
>>> -	{
>>> +	if (resolve_services) {
>>>   		printf("%*s:", addr_width, nl_proto_n2a(prot, prot_name,
>>>   					sizeof(prot_name)));
>>> -	}
>>> +	} else
>>> +		printf("%*d:", addr_width, prot);
>>> +

>>     Extra empty line hardly needed here. And if iproute2 follows the Linux
>> kernel style, {} should be used in all arms of the *if* statement (since
>> it's used in one case).

>>>
>>>   	if (pid == -1) {
>>>   		printf("%-*s ", serv_width, "*");

> You mean change to this ?

> 	if (resolve_services) {
>   		printf("%*s:", addr_width, nl_proto_n2a(prot, prot_name,
>   					sizeof(prot_name)));
> 	} else {
> 		printf("%*d:", addr_width, prot);
>          }

    Yes (but indent } with tab please).

> Thanks,

WBR, Sergei