From: "Christoph Lameter (Ampere)" <cl@linux.com>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: vbabka@suse.cz, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
roman.gushchin@linux.dev, 42.hyeyoo@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page
Date: Thu, 11 Apr 2024 09:51:13 -0700 (PDT) [thread overview]
Message-ID: <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> (raw)
In-Reply-To: <20240411091832.608280-1-haifeng.xu@shopee.com>
On Thu, 11 Apr 2024, Haifeng Xu wrote:
> @@ -1875,6 +1875,13 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node,
> struct slab *slab;
> unsigned int order = oo_order(oo);
>
> + /*
> + * If fallback to the minimum order allocation and the order is 0,
> + * clear the __GFP_COMP flag.
> + */
> + if (order == 0)
> + flags = flags & ~__GFP_COMP;
This would be better placed in allocate_slab() when the need for a
fallback to a lower order is detected after the first call to alloc_slab_page().
next prev parent reply other threads:[~2024-04-11 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 9:18 [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page Haifeng Xu
2024-04-11 16:51 ` Christoph Lameter (Ampere) [this message]
2024-04-12 8:01 ` Vlastimil Babka
2024-04-12 12:17 ` Matthew Wilcox
2024-04-12 14:14 ` Haifeng Xu
2024-04-12 14:18 ` Matthew Wilcox
2024-04-12 9:34 ` Haifeng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com \
--to=cl@linux.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=haifeng.xu@shopee.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.