From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jike Song Subject: Re: [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM Date: Sat, 06 Dec 2014 12:30:39 +0800 Message-ID: <5482866F.70500@intel.com> References: <547FC5DE.4010701@intel.com> <1417769421.11297.37.camel@nilsson.home.kraxel.org> <5481AD24.3000703@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 111C36E1A1 for ; Fri, 5 Dec 2014 20:33:31 -0800 (PST) In-Reply-To: <5481AD24.3000703@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paolo Bonzini Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Q0MgQW5keSA6KQoKT24gMTIvMDUvMjAxNCAwOTowMyBQTSwgUGFvbG8gQm9uemluaSB3cm90ZToK Pgo+IE9uIDA1LzEyLzIwMTQgMDk6NTAsIEdlcmQgSG9mZm1hbm4gd3JvdGU6Cj4+IEEgZmV3IGNv bW1lbnRzIG9uIHRoZSBrZXJuZWwgc3R1ZmYgKGJyaWVmIGxvb2sgc28gZmFyLCBhbHNvCj4+IGNv bXBpbGUtdGVzdGVkIG9ubHksIGludGVsIGdmeCBvbiBteSB0ZXN0IG1hY2hpbmUgaXMgdG9vIG9s ZCkuCj4+Cj4+ICAgKiBOb3RpY2VkIHRoZSBrZXJuZWwgYml0cyBkb24ndCBldmVuIGNvbXBpbGUg d2hlbiBjb25maWd1cmVkIGFzCj4+ICAgICBtb2R1bGUuICBFdmVyeXRoaW5nICh2Z3QsIGk5MTUs IGt2bSkgbXVzdCBiZSBjb21waWxlZCBpbnRvIHRoZQo+PiAgICAga2VybmVsLgo+Cj4gSSdsbCBh ZGQgdGhhdCB0aGUgcGF0Y2ggaXMgYmFzaWNhbGx5IGltcG9zc2libGUgdG8gcmV2aWV3IHdpdGgg YWxsIHRoZQo+IFhlbkdUIGJpdHMgc3RpbGwgaW4uICBGb3IgZXhhbXBsZSwgdGhlIHg4NiBlbXVs YXRvciBzZWVtcyB0byBiZQo+IHVubmVjZXNzYXJ5IGZvciBLVk1HVCwgYnV0IEkgYW0gbm90IDEw MCUgc3VyZS4KPgoKVGhpcyBpcyBub3QgcmVhZHkgZm9yIG1lcmdlIHlldCwgcGxlYXNlIHdhaXQg Zm9yIGEgd2hpbGUsIHdlJ2xsIGhhdmUKWGVuL0tWTSBzcGVjaWZpYyBjb2RlIHNlcGFyYXRlZC4K CkJUVywgZGVmaW5pdGVseSB5b3UgYXJlIHJpZ2h0LCB0aGUgZW11bGF0b3IgaXMgdW5uZWNlc3Nh cnkgZm9yIEtWTUdULAphbmQgLi4uIHVubmVjZXNzYXJ5IGZvciBYZW5HVCA6KQoKPiBJIHdvdWxk IGxpa2UgYSBjbGVhciB1bmRlcnN0YW5kaW5nIG9mIHdoeS9ob3cgQW5kcmV3IEJhcm5lcyB3YXMg YWJsZSB0bwo+IGRvIGk5MTUgcGFzc3Rocm91Z2ggKEdWVC1kKSB3aXRob3V0IGhhY2tpbmcgdGhl IElTQSBicmlkZ2UsIGFuZCB3aHkgdGhpcwo+IGRvZXMgbm90IGFwcGx5IHRvIEdWVC1nLgoKQUZB SUssIHRoZSBncmFwaGljcyBkcml2ZXJzIG5lZWQgdG8gZmlndXJlIG91dCB0aGUgb2Zmc2V0IG9m CnNvbWUgTU1JTyByZWdpc3RlcnMsIGJ5IHRoZSBJRHMgb2YgdGhpcyBJU0EgYnJpZGdlLiBJdCBz aW1wbHkgd29uJ3Qgd29yawp3aXRob3V0IHRoaXMgaW5mb3JtYXRpb24uCgpUYWxrZWQgd2l0aCBB bmR5IGFib3V0IHRoZSBwYXNzLXRocm91Z2ggYnV0IEkgZG9uJ3QgaGF2ZSBoaXMgaW1wbGVtZW50 YXRpb24sCkNDIEFuZHkgZm9yIGhpcyBhZHZpY2UgOikKCj4KPiBQYW9sbwo+CgpUaGFua3MgZm9y IHJldmlldy4gV291bGQgeW91IHBsZWFzZSBhbHNvIGhhdmUgYSBsb29rIGF0IHRoZSBpc3N1ZXMg SSBtZW50aW9uZWQKaW4gdGhlIG9yaWdpbmFsIGVtYWlsPyB0aGV5IGFyZSBtb3N0IEtWTS1yZWxh dGVkOiB0aGUgU1JDVSB0cmlja2luZXNzLCBkb21pZCwKYW5kIHRoZSBtZW1zbG90IGNyZWF0ZWQg aW4ga2VybmVsLgoKVGhhbmsgeW91IQoKLS0KVGhhbmtzLApKaWtlCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbaLFEdc (ORCPT ); Fri, 5 Dec 2014 23:33:32 -0500 Received: from mga11.intel.com ([192.55.52.93]:31067 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbaLFEda (ORCPT ); Fri, 5 Dec 2014 23:33:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="425800903" Message-ID: <5482866F.70500@intel.com> Date: Sat, 06 Dec 2014 12:30:39 +0800 From: Jike Song User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Paolo Bonzini CC: kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andrew Barnes Subject: Re: [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM References: <547FC5DE.4010701@intel.com> <1417769421.11297.37.camel@nilsson.home.kraxel.org> <5481AD24.3000703@redhat.com> In-Reply-To: <5481AD24.3000703@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC Andy :) On 12/05/2014 09:03 PM, Paolo Bonzini wrote: > > On 05/12/2014 09:50, Gerd Hoffmann wrote: >> A few comments on the kernel stuff (brief look so far, also >> compile-tested only, intel gfx on my test machine is too old). >> >> * Noticed the kernel bits don't even compile when configured as >> module. Everything (vgt, i915, kvm) must be compiled into the >> kernel. > > I'll add that the patch is basically impossible to review with all the > XenGT bits still in. For example, the x86 emulator seems to be > unnecessary for KVMGT, but I am not 100% sure. > This is not ready for merge yet, please wait for a while, we'll have Xen/KVM specific code separated. BTW, definitely you are right, the emulator is unnecessary for KVMGT, and ... unnecessary for XenGT :) > I would like a clear understanding of why/how Andrew Barnes was able to > do i915 passthrough (GVT-d) without hacking the ISA bridge, and why this > does not apply to GVT-g. AFAIK, the graphics drivers need to figure out the offset of some MMIO registers, by the IDs of this ISA bridge. It simply won't work without this information. Talked with Andy about the pass-through but I don't have his implementation, CC Andy for his advice :) > > Paolo > Thanks for review. Would you please also have a look at the issues I mentioned in the original email? they are most KVM-related: the SRCU trickiness, domid, and the memslot created in kernel. Thank you! -- Thanks, Jike