From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: jiri@resnulli.us, sfeldma@gmail.com, jhs@mojatatu.com,
bcrl@kvack.org, john.fastabend@gmail.com,
stephen@networkplumber.org, linville@tuxdriver.com,
nhorman@tuxdriver.com, nicolas.dichtel@6wind.com,
vyasevic@redhat.com, f.fainelli@gmail.com,
buytenh@wantstofly.org, aviadr@mellanox.com,
netdev@vger.kernel.org, davem@davemloft.net,
shm@cumulusnetworks.com, gospo@cumulusnetworks.com
Subject: Re: [PATCH 1/3] netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature flag for switch device offloads
Date: Fri, 05 Dec 2014 23:46:23 -0800 [thread overview]
Message-ID: <5482B44F.2050509@cumulusnetworks.com> (raw)
In-Reply-To: <20141205224320.GA22992@casper.infradead.org>
On 12/5/14, 2:43 PM, Thomas Graf wrote:
> On 12/04/14 at 06:26pm, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This is a generic high level feature flag for all switch asic features today.
>>
>> switch drivers set this flag on switch ports. Logical devices like
>> bridge, bonds, vxlans can inherit this flag from their slaves/ports.
>>
>> I had to use SWITCH in the name to avoid ambiguity with other feature
>> flags. But, since i have been harping about not calling it 'switch',
>> I am welcome to any suggestions :)
>>
>> An alternative to using a feature flag is to use a IFF_HW_OFFLOAD
>> in net_device_flags.
> What does this flag indicate specifically? What driver would
> implement ndo_bridge_setlink() but not set this flag?
>
> I think it should be clearly documented when this flag is to bet set.
I mentioned it as an alternative because it was there in my RFC patch.
There is no code for it yet.
And I will get rid of the comment in v2.
next prev parent reply other threads:[~2014-12-06 7:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 2:26 [PATCH 1/3] netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature flag for switch device offloads roopa
2014-12-05 3:21 ` Jianhua Xie
2014-12-05 4:17 ` Roopa Prabhu
2014-12-05 4:43 ` Jianhua Xie
2014-12-05 6:08 ` Scott Feldman
2014-12-05 6:32 ` John Fastabend
2014-12-05 6:47 ` Scott Feldman
2014-12-05 7:41 ` Jiri Pirko
2014-12-05 14:16 ` Roopa Prabhu
2014-12-05 18:53 ` Scott Feldman
2014-12-05 19:07 ` Roopa Prabhu
2014-12-05 12:06 ` Jamal Hadi Salim
2014-12-05 12:17 ` Jiri Pirko
2014-12-05 12:50 ` Jamal Hadi Salim
2014-12-05 22:43 ` Thomas Graf
2014-12-06 7:46 ` Roopa Prabhu [this message]
2014-12-06 10:14 ` Thomas Graf
2014-12-06 18:59 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5482B44F.2050509@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=aviadr@mellanox.com \
--cc=bcrl@kvack.org \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.dichtel@6wind.com \
--cc=sfeldma@gmail.com \
--cc=shm@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.