From mboxrd@z Thu Jan 1 00:00:00 1970 From: agraf@suse.de (Alexander Graf) Date: Sun, 07 Dec 2014 10:49:12 +0100 Subject: [PATCH v8 3/3] net: hisilicon: new hip04 ethernet driver In-Reply-To: <5483C977.2060308@huawei.com> References: <1397869980-21187-1-git-send-email-zhangfei.gao@linaro.org> <1397869980-21187-4-git-send-email-zhangfei.gao@linaro.org> <5483A279.5000503@suse.de> <5483C977.2060308@huawei.com> Message-ID: <54842298.2010007@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07.12.14 04:28, Ding Tianhong wrote: > On 2014/12/7 8:42, Alexander Graf wrote: >> On 19.04.14 03:13, Zhangfei Gao wrote: >>> Support Hisilicon hip04 ethernet driver, including 100M / 1000M controller. >>> The controller has no tx done interrupt, reclaim xmitted buffer in the poll. >>> >>> Signed-off-by: Zhangfei Gao >> >> Is this driver still supposed to go upstream? I presume this was the >> last submission and it's been quite some time ago :) >> > > yes, it is really a long time, but The hip04 did not support tx irq, > we couldn't get any better idea to fix this defect, do you have any suggestion? Well, if hardware doesn't have a TX irq I don't see there's anything we can do to fix that ;). Dave, what's your take here? Should we keep a driver from going upstream just because the hardware is partly broken? I'd really prefer to have an upstream driver on that SoC rather than some random (eventually even more broken) downstream code. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v8 3/3] net: hisilicon: new hip04 ethernet driver Date: Sun, 07 Dec 2014 10:49:12 +0100 Message-ID: <54842298.2010007@suse.de> References: <1397869980-21187-1-git-send-email-zhangfei.gao@linaro.org> <1397869980-21187-4-git-send-email-zhangfei.gao@linaro.org> <5483A279.5000503@suse.de> <5483C977.2060308@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5483C977.2060308@huawei.com> Sender: netdev-owner@vger.kernel.org To: Ding Tianhong , Zhangfei Gao Cc: davem@davemloft.net, linux@arm.linux.org.uk, arnd@arndb.de, f.fainelli@gmail.com, sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, David.Laight@ACULAB.COM, eric.dumazet@gmail.com, xuwei5@hisilicon.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 07.12.14 04:28, Ding Tianhong wrote: > On 2014/12/7 8:42, Alexander Graf wrote: >> On 19.04.14 03:13, Zhangfei Gao wrote: >>> Support Hisilicon hip04 ethernet driver, including 100M / 1000M controller. >>> The controller has no tx done interrupt, reclaim xmitted buffer in the poll. >>> >>> Signed-off-by: Zhangfei Gao >> >> Is this driver still supposed to go upstream? I presume this was the >> last submission and it's been quite some time ago :) >> > > yes, it is really a long time, but The hip04 did not support tx irq, > we couldn't get any better idea to fix this defect, do you have any suggestion? Well, if hardware doesn't have a TX irq I don't see there's anything we can do to fix that ;). Dave, what's your take here? Should we keep a driver from going upstream just because the hardware is partly broken? I'd really prefer to have an upstream driver on that SoC rather than some random (eventually even more broken) downstream code. Alex