From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Sakamoto Subject: Re: [PATCH 1/2] ALSA: firewire-lib: remove rx_blocks_for_midi quirk Date: Sun, 07 Dec 2014 22:31:57 +0900 Message-ID: <548456CD.1070701@sakamocchi.jp> References: <5474FA18.7000501@ladisch.de> <5475E211.3040106@sakamocchi.jp> <5475E5F6.2080709@ladisch.de> <54771CCC.4090101@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp310.phy.lolipop.jp (smtp310.phy.lolipop.jp [210.157.22.78]) by alsa0.perex.cz (Postfix) with ESMTP id AEDEB260682 for ; Sun, 7 Dec 2014 14:32:03 +0100 (CET) In-Reply-To: <54771CCC.4090101@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch , Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Iwai-san, On Nov 27 2014 21:45, Takashi Sakamoto wrote: > On Nov 26 2014 23:38, Clemens Ladisch wrote: >> Takashi Sakamoto wrote: >>> On Nov 26 2014 06:52, Clemens Ladisch wrote: >>>> There are several devices that expect to receive MIDI data only in the >>>> first eight data blocks of a packet. If the driver restricts the data >>>> rate to the allowed rate (as mandated by the specification, but not yet >>>> implemented by this driver), this happens naturally. Therefore, there >>>> is no reason to ever try to use more data packets with any device. >>>> >>>> Signed-off-by: Clemens Ladisch >>>> --- >>>> sound/firewire/amdtp.c | 10 +++++++--- >>>> sound/firewire/amdtp.h | 3 --- >>>> sound/firewire/bebob/bebob_stream.c | 7 ------- >>>> sound/firewire/fireworks/fireworks_stream.c | 5 ----- >>>> 4 files changed, 7 insertions(+), 18 deletions(-) > > Reviewed-by: Takashi Sakamoto > Tested-by: Takashi Sakamoto > > I tested these two patch with below devices. All of them can transmit > MIDI messages correctly at any sampling transfer tates. > > M-Audio: FIreWire 1814 (snd-bebob) > M-Audio: FireWire 410 (snd-bebob) > M-Audio: FireWire AudioPhile (snd-bebob) > M-Audio: Ozonic (snd-bebob) > Yamaha: GO44 (snd-bebob) > Yamaha: GO46 (snd-bebob) > Echo Audio: AudioFire4 (snd-fireworks) > Echo Audio: AudioFirePre8 (snd-fireworks) > TC Electronic: Impact Twin (snd-dice) > > These two patches solves one of issues which I wrote in my report. > 9.5 A lack of throttles for MIDI messages in outgoing stream > https://github.com/takaswie/alsa-firewire-report I think these two patches are deserved to merge. Could you apply these two patches to linux-next? Regards Takashi Sakamoto o-takashi@sakamocchi.jp