From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Date: Mon, 08 Dec 2014 09:16:37 +0000 Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string Message-Id: <54856C75.1050309@nod.at> List-Id: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Am 08.12.2014 um 08:11 schrieb Julia Lawall: >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c >>> index 35aef5e..0a9c41f 100644 >>> --- a/drivers/mtd/nand/s3c2410.c >>> +++ b/drivers/mtd/nand/s3c2410.c >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) >>> >>> cpu_type = platform_get_device_id(pdev)->driver_data; >>> >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); >>> + pr_debug("%s(%p)\n", __func__, pdev); >> >> I think we can drop the line completely. >> We have ftrace to trace function calls... > > Should the "initialised ok" at the end of the function be remove as well? > > Will it be confusing if this cleanup is done in this function, but not in > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > example? Hmm, this driver seems to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XxuRD-0001t1-Ey for linux-mtd@lists.infradead.org; Mon, 08 Dec 2014 09:17:04 +0000 Message-ID: <54856C75.1050309@nod.at> Date: Mon, 08 Dec 2014 10:16:37 +0100 From: Richard Weinberger MIME-Version: 1.0 To: Julia Lawall Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-samsung-soc@vger.kernel.org, "kernel-janitors@vger.kernel.org" , linux@rasmusvillemoes.dk, LKML , Kukjin Kim , "linux-mtd@lists.infradead.org" , Joe Perches , Brian Norris , David Woodhouse , "linux-arm-kernel@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 08.12.2014 um 08:11 schrieb Julia Lawall: >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c >>> index 35aef5e..0a9c41f 100644 >>> --- a/drivers/mtd/nand/s3c2410.c >>> +++ b/drivers/mtd/nand/s3c2410.c >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) >>> >>> cpu_type = platform_get_device_id(pdev)->driver_data; >>> >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); >>> + pr_debug("%s(%p)\n", __func__, pdev); >> >> I think we can drop the line completely. >> We have ftrace to trace function calls... > > Should the "initialised ok" at the end of the function be remove as well? > > Will it be confusing if this cleanup is done in this function, but not in > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > example? Hmm, this driver seems to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string Date: Mon, 08 Dec 2014 10:16:37 +0100 Message-ID: <54856C75.1050309@nod.at> References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: Kukjin Kim , "kernel-janitors@vger.kernel.org" , linux@rasmusvillemoes.dk, Joe Perches , David Woodhouse , Brian Norris , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, "linux-mtd@lists.infradead.org" , LKML List-Id: linux-samsung-soc@vger.kernel.org Am 08.12.2014 um 08:11 schrieb Julia Lawall: >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c >>> index 35aef5e..0a9c41f 100644 >>> --- a/drivers/mtd/nand/s3c2410.c >>> +++ b/drivers/mtd/nand/s3c2410.c >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) >>> >>> cpu_type = platform_get_device_id(pdev)->driver_data; >>> >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); >>> + pr_debug("%s(%p)\n", __func__, pdev); >> >> I think we can drop the line completely. >> We have ftrace to trace function calls... > > Should the "initialised ok" at the end of the function be remove as well? > > Will it be confusing if this cleanup is done in this function, but not in > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > example? Hmm, this driver seems to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard@nod.at (Richard Weinberger) Date: Mon, 08 Dec 2014 10:16:37 +0100 Subject: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string In-Reply-To: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> Message-ID: <54856C75.1050309@nod.at> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 08.12.2014 um 08:11 schrieb Julia Lawall: >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c >>> index 35aef5e..0a9c41f 100644 >>> --- a/drivers/mtd/nand/s3c2410.c >>> +++ b/drivers/mtd/nand/s3c2410.c >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) >>> >>> cpu_type = platform_get_device_id(pdev)->driver_data; >>> >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); >>> + pr_debug("%s(%p)\n", __func__, pdev); >> >> I think we can drop the line completely. >> We have ftrace to trace function calls... > > Should the "initialised ok" at the end of the function be remove as well? > > Will it be confusing if this cleanup is done in this function, but not in > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > example? Hmm, this driver seems to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. Thanks, //richard