From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XxunC-0004Ot-Hg for linux-mtd@lists.infradead.org; Mon, 08 Dec 2014 09:39:47 +0000 Message-ID: <548571CA.90803@nod.at> Date: Mon, 08 Dec 2014 10:39:22 +0100 From: Richard Weinberger MIME-Version: 1.0 To: Tanya Brokhman , dedekind1@gmail.com Subject: Re: [PATCH 2/6] UBI: Fastmap: Don't allocate new ubi_wl_entry objects References: <1417347340-6872-1-git-send-email-richard@nod.at> <1417347340-6872-3-git-send-email-richard@nod.at> <54856305.2070408@codeaurora.org> <54856BE6.5090003@nod.at> <54857155.3040801@codeaurora.org> In-Reply-To: <54857155.3040801@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 08.12.2014 um 10:37 schrieb Tanya Brokhman: > On 12/8/2014 11:14 AM, Richard Weinberger wrote: >> Am 08.12.2014 um 09:36 schrieb Tanya Brokhman: >>> On 11/30/2014 1:35 PM, Richard Weinberger wrote: >>>> There is no need to allocate new ones every time, we can reuse >>>> the existing ones. >>>> This makes the code cleaner and more easy to follow. >>>> >>>> Signed-off-by: Richard Weinberger >>>> --- >>>> drivers/mtd/ubi/fastmap.c | 31 +++++-------------------------- >>>> drivers/mtd/ubi/wl.c | 11 +++++++---- >>>> 2 files changed, 12 insertions(+), 30 deletions(-) >>>> >>>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c >>>> index db3defd..9507702 100644 >>>> --- a/drivers/mtd/ubi/fastmap.c >>>> +++ b/drivers/mtd/ubi/fastmap.c >>>> @@ -1446,19 +1446,6 @@ int ubi_update_fastmap(struct ubi_device *ubi) >>>> } >>>> >>>> new_fm->used_blocks = ubi->fm_size / ubi->leb_size; >>> >>> Not related to this patch, but looking at this function it got me thinking: why do we need to re-calculate new_fm->used_blocks (and check calculated value) each time? fm_size >>> doesn't changed at runtime. leb_size sure does not, so fm->used_blocks can be ubi device parameter and calculated & tested only once, and not each time we write fastmap. Correct? >> >> If you dig deeper into the patch set you'll notice that the fastmap size can change. :-) >> > > oh, ok. sorry, still in the middle of the review. This is perfectly fine. I really a appreciate your reviews! Thanks, //richard