From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] console: allocate ring buffer earlier Date: Mon, 08 Dec 2014 11:50:18 +0000 Message-ID: <5485907A.2060208@linaro.org> References: <5481F18C020000780004D535@mail.emea.novell.com> <54824832.9000607@linaro.org> <548574ED020000780004D9D9@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xxwpc-0003tk-IA for xen-devel@lists.xenproject.org; Mon, 08 Dec 2014 11:50:24 +0000 Received: by mail-wg0-f43.google.com with SMTP id l18so6040130wgh.2 for ; Mon, 08 Dec 2014 03:50:22 -0800 (PST) In-Reply-To: <548574ED020000780004D9D9@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Tim Deegan , Daniel Kiper , Ian Jackson , Ian Campbell , xen-devel List-Id: xen-devel@lists.xenproject.org On 08/12/14 08:52, Jan Beulich wrote: >>>> On 06.12.14 at 01:05, wrote: >> On 05/12/2014 16:55, Jan Beulich wrote: >> > I didn't change ARM, as I wasn't sure how far ahead this call could be >>> pulled. >> >> AFAIU, the new function only requires that the page table are setup >> (because of the alloc_xenheap_pages). >> >> So console_init_mem could be called right after console_init_preirq. > > No, it requires that alloc_xenheap_pages() works, i.e. it surely can't > be placed before the end_boot_allocator() invocation. Which is the case with the place I was suggesting... On ARM, end_boot_allocator is called in setup_mm which is called before console_init_preirq. Regards, -- Julien Grall