All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Tanya Brokhman <tlinder@codeaurora.org>, dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure
Date: Mon, 08 Dec 2014 14:07:07 +0100	[thread overview]
Message-ID: <5485A27B.5060409@nod.at> (raw)
In-Reply-To: <5485A0E8.4050901@codeaurora.org>

Am 08.12.2014 um 14:00 schrieb Tanya Brokhman:
>>>> Maybe the case you've described is powercut safe, but there can be other unsafe cases.
>>>> Let's stay on the safe side and be paranoid, it does not hurt.
>>>> If fastmap has proven stable we can start with tricky optimizations.
>>>
>>> I'm sorry that I'm being petty here but the commit msg states that you "notify the user in case of update fastamap failure". It says nothing about you failing ubi_wl_get_peb as
>>> well. And this is a major change. At least divide this into 2 patches (so I can disagree to the function failing and agree to the msg to user :) )
>>
>> With user I meant users of that function.
> 
> I still don't like it.
> Leaving this one for Artem... sorry

As I said, as soon we all consider fastmap mature and stable we can start with optimizations.
But as of now I want all logic to be on the safe side. This is how all fastmap code is designed.

Thanks,
//richard

  reply	other threads:[~2014-12-08 13:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 11:35 Fastmap update v2 (pile 2) Richard Weinberger
2014-11-30 11:35 ` [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system Richard Weinberger
2014-11-30 11:35   ` Richard Weinberger
2014-12-07  8:13   ` Tanya Brokhman
2014-12-07  9:54     ` Richard Weinberger
2014-12-07 11:32       ` Tanya Brokhman
2014-12-07 11:34         ` Richard Weinberger
2014-12-07 13:26           ` Tanya Brokhman
2014-12-07 13:46             ` Richard Weinberger
2014-12-17 20:01   ` Guido Martínez
2014-12-17 20:01     ` Guido Martínez
2014-11-30 11:35 ` [PATCH 2/6] UBI: Fastmap: Don't allocate new ubi_wl_entry objects Richard Weinberger
2014-11-30 11:35   ` Richard Weinberger
2014-12-07 13:49   ` Tanya Brokhman
2014-12-08  8:36   ` Tanya Brokhman
2014-12-08  9:14     ` Richard Weinberger
2014-12-08  9:37       ` Tanya Brokhman
2014-12-08  9:39         ` Richard Weinberger
2014-12-18  1:18   ` Guido Martínez
2014-12-18  1:18     ` Guido Martínez
2014-12-18  1:21     ` Richard Weinberger
2014-12-18  1:21       ` Richard Weinberger
2014-11-30 11:35 ` [PATCH 3/6] UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure Richard Weinberger
2014-11-30 11:35   ` Richard Weinberger
2014-12-07 13:59   ` Tanya Brokhman
2014-12-07 14:22     ` Richard Weinberger
2014-12-08  6:58       ` Tanya Brokhman
2014-12-08  9:11         ` Richard Weinberger
2014-12-08 13:00           ` Tanya Brokhman
2014-12-08 13:07             ` Richard Weinberger [this message]
2014-12-08 13:20             ` Richard Weinberger
2014-11-30 11:35 ` [PATCH 4/6] UBI: Fastmap: Wrap fastmap specific function in a ifdef Richard Weinberger
2014-11-30 11:35   ` Richard Weinberger
2014-12-07 14:05   ` Tanya Brokhman
2014-11-30 11:35 ` [PATCH 5/6] UBI: Fastmap: Fix fastmap usage in ubi_volume_notify() Richard Weinberger
2014-11-30 11:35   ` Richard Weinberger
2014-12-07 14:06   ` Tanya Brokhman
2014-11-30 11:35 ` [PATCH 6/6] UBI: Fastmap: Fix memory leak while attaching Richard Weinberger
2014-11-30 11:35   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5485A27B.5060409@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tlinder@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.