From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
ufimtseva@gmail.com, keir@xen.org
Subject: Re: [PATCH 2/4] sysctl/libxl: Add interface for returning IO topology data
Date: Mon, 08 Dec 2014 09:56:19 -0500 [thread overview]
Message-ID: <5485BC13.3030403@oracle.com> (raw)
In-Reply-To: <54857061020000780004D999@mail.emea.novell.com>
>>> Additionally please add IN and OUT annotations. When I first saw
>>> this I assumed they would all be OUT (in which case the long running
>>> loop problem mentioned in the reply to one of the other patches
>>> wouldn't have been there), matching their CPU counterpart...
>> I don't follow this. Are you saying that if ti->max_devs in patch 3/4 is
>> an IN (which it is) then we don't have to guard for long-running loops?
> If they were all OUT then there wouldn't be a way for the entire
> operation to be fooled into going over more devices than there are
> in the system.
Assuming I add continuations to the loop, too many devices wouldn't be a
problem for the hypervisor, would it? If an unreasonable number is
provided then eventually copy_from_guest() will fault.
-boris
next prev parent reply other threads:[~2014-12-08 14:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 21:34 [PATCH 0/4] Display IO topology when PXM data is available Boris Ostrovsky
2014-12-02 21:34 ` [PATCH 1/4] pci: Do not ignore device's PXM information Boris Ostrovsky
2014-12-03 15:01 ` Andrew Cooper
2014-12-03 15:19 ` Boris Ostrovsky
2014-12-05 15:53 ` Jan Beulich
2014-12-05 17:02 ` Boris Ostrovsky
2014-12-02 21:34 ` [PATCH 2/4] sysctl/libxl: Add interface for returning IO topology data Boris Ostrovsky
2014-12-03 15:20 ` Andrew Cooper
2014-12-03 15:37 ` Boris Ostrovsky
2014-12-04 11:24 ` Wei Liu
2014-12-04 11:55 ` Dario Faggioli
2014-12-04 16:26 ` Boris Ostrovsky
2014-12-04 16:44 ` Andrew Cooper
2014-12-04 17:11 ` Jan Beulich
2014-12-05 15:55 ` Jan Beulich
2014-12-05 16:03 ` Jan Beulich
2014-12-05 17:10 ` Boris Ostrovsky
2014-12-08 8:33 ` Jan Beulich
2014-12-08 14:56 ` Boris Ostrovsky [this message]
2014-12-08 15:19 ` Jan Beulich
2014-12-08 15:30 ` Andrew Cooper
2014-12-02 21:34 ` [PATCH 3/4] sysctl/libxl: Provide information about IO topology Boris Ostrovsky
2014-12-04 12:22 ` Dario Faggioli
2014-12-04 13:28 ` Ian Campbell
2014-12-05 15:59 ` Jan Beulich
2014-12-02 21:34 ` [PATCH 4/4] libxl: Switch to using new topology interface Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485BC13.3030403@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=ufimtseva@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.