From: Sasha Levin <sasha.levin@oracle.com>
To: Kirill Smelkov <kirr@nexedi.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/liblockdep: Fix debug_check thinko in mutex destroy
Date: Mon, 08 Dec 2014 09:59:54 -0500 [thread overview]
Message-ID: <5485BCEA.30207@oracle.com> (raw)
In-Reply-To: <1418036879-31944-1-git-send-email-kirr@nexedi.com>
On 12/08/2014 06:07 AM, Kirill Smelkov wrote:
> In mutex destroy code currently we pass to debug_check_no_locks_freed()
>
> [mem_from, mem_end)
>
> address region. But debug_check_no_locks_freed() accepts
>
> mem_from, mem_*len*
>
> i.e. second parameter is region length, not end address. And it was
> always so, starting from 2006 (fbb9ce95 "lockdep: core").
>
> Fix it, or else on a mutex destroy we wrongly check
> much-wider-than-mutex region and can find not-yet-released other locks
> there and wrongly report BUGs on them.
Great catch, thanks!
Thanks,
Sasha
next prev parent reply other threads:[~2014-12-08 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 11:07 [PATCH] tools/liblockdep: Fix debug_check thinko in mutex destroy Kirill Smelkov
2014-12-08 14:59 ` Sasha Levin [this message]
2014-12-14 14:21 ` Kirill Smelkov
2014-12-14 14:30 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485BCEA.30207@oracle.com \
--to=sasha.levin@oracle.com \
--cc=kirr@nexedi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.