From: Antti Palosaari <crope@iki.fi>
To: Benjamin Larsson <benjamin@southpole.se>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/2] mn88472: fix firmware loading
Date: Mon, 08 Dec 2014 19:35:33 +0200 [thread overview]
Message-ID: <5485E165.2040506@iki.fi> (raw)
In-Reply-To: <548587AA.80200@southpole.se>
Moikka!
On 12/08/2014 01:12 PM, Benjamin Larsson wrote:
> On 12/07/2014 11:36 PM, Antti Palosaari wrote:
>> On 12/08/2014 12:10 AM, Benjamin Larsson wrote:
>>> The firmware must be loaded one byte at a time via the 0xf6 register.
>>
>> I don't think so. Currently it downloads firmware in 22 byte chunks
>> and it seems to work, at least for me, both mn88472 and mn88473.
>
> With both these changes I get much better sensitivity. So something is
> better then before. I will track down the needed changes and respin the
> patches.
I suspect it is that initialization of all registers which has something
to do with sensitivity. I haven't tested if firmware uploading is
critical, what happens when some byte is skipped or so...
Did you saw there is config parameter i2c_wr_max? Setting it to '1' does
same what that your patch did, but leaves amount of max I2C bytes
configurable...
Anyhow, good finding, which needs to be track down.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-12-08 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 22:10 [PATCH 1/2] mn88472: load demodulator register defaults Benjamin Larsson
2014-12-07 22:10 ` [PATCH 2/2] mn88472: fix firmware loading Benjamin Larsson
2014-12-07 22:36 ` Antti Palosaari
2014-12-08 11:12 ` Benjamin Larsson
2014-12-08 17:35 ` Antti Palosaari [this message]
2014-12-08 16:04 ` Benjamin Larsson
2014-12-08 17:46 ` Antti Palosaari
2014-12-08 18:54 ` Benjamin Larsson
2014-12-07 22:25 ` [PATCH 1/2] mn88472: load demodulator register defaults Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485E165.2040506@iki.fi \
--to=crope@iki.fi \
--cc=benjamin@southpole.se \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.