From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C
Date: Tue, 09 Dec 2014 07:17:59 +0100 [thread overview]
Message-ID: <54869417.50205@denx.de> (raw)
In-Reply-To: <CAPnjgZ1SF5NfbNRBKLzm6kPAZsx9ereSPj9Sw4Sv6smnhiFDMQ@mail.gmail.com>
Hello Simon,
Am 09.12.2014 06:31, schrieb Simon Glass:
> Hi,
>
> On Dec 5, 2014 8:32 AM, "Simon Glass" <sjg@chromium.org> wrote:
>>
>> The uclass implements the same operations as the current I2C framework but
>> makes some changes to make it fit driver model better:
>>
>> - Remove the chip address from API calls
>> - Remove the address length from API calls
>> - Remove concept of 'current' I2C bus
>> - Drop all existing init functions
>>
>> Acked-by: Heiko Schocher <hs@denx.de>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v5:
>> - Add a function comment for i2c_probe_chip()
>> - Add an assert for offset_len in i2c_setup_offset()
>> - Add more detail to return value comment on get_buf_speed()
>> - Add more detail to return value comment on xfer() method
>> - Fix -INVAL typo
>> - Make i2c_get_bus_speed() independent of i2c_set_bus_speed()
>> - Split DM_I2C_CHIP_RD_ADDRESS into read and write varaints
>> - Update comments in struct i2c_msg to allow buf to be NULL
>> - Use a NULL buffer in i2c_probe_chip()
>
> Any. Ore comments please? Otherwise I will retest and apply this version.
I am fine with it. Thanks for your and Masahiros work!
I hope I find some time to look into using platform data, as I have
no board which uses DT support in U-Boot ...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-12-09 6:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 15:32 [U-Boot] [PATCH v5 0/11] dm: Add I2C support and convert sandbox, tegra Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C Simon Glass
2014-12-09 5:31 ` Simon Glass
2014-12-09 5:37 ` Masahiro Yamada
2014-12-09 6:17 ` Heiko Schocher [this message]
2014-12-09 13:54 ` Simon Glass
2014-12-10 13:23 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 02/11] dm: i2c: Implement driver model support in the i2c command Simon Glass
2014-12-10 13:24 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 03/11] dm: i2c: Add I2C emulation driver for sandbox Simon Glass
2014-12-10 13:29 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 04/11] dm: i2c: Add a sandbox I2C driver Simon Glass
2014-12-10 13:19 ` Masahiro Yamada
2014-12-10 15:32 ` Simon Glass
2014-12-10 13:33 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 05/11] dm: i2c: Add an I2C EEPROM simulator Simon Glass
2014-12-10 13:19 ` Masahiro Yamada
2014-12-10 18:00 ` Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 06/11] dm: i2c: config: Enable I2C for sandbox using driver model Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 07/11] dm: i2c: dts: Add an I2C bus for sandbox Simon Glass
2014-12-10 13:27 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 08/11] dm: Add a simple EEPROM driver Simon Glass
2014-12-10 13:29 ` Masahiro Yamada
2014-12-05 15:32 ` [U-Boot] [PATCH v5 09/11] dm: i2c: Add tests for I2C Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 10/11] dm: device: Add newline to debug() messages Simon Glass
2014-12-05 15:32 ` [U-Boot] [PATCH v5 11/11] dm: i2c: tegra: Convert to driver model Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54869417.50205@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.