From: "Michel Dänzer" <michel@daenzer.net>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/radeon: add command submission IDs
Date: Tue, 09 Dec 2014 18:01:39 +0900 [thread overview]
Message-ID: <5486BA73.7020902@daenzer.net> (raw)
In-Reply-To: <1418055073-2211-3-git-send-email-deathsimple@vodafone.de>
On 09.12.2014 01:11, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> This patch adds a new 64bit ID as a result to each command submission.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
I noticed a few spelling mistakes, see below.
Other than these minor nits, I haven't noticed any problems in this
series, though I haven't looked at it in too much detail.
> +/*
> + * ID sequences
> + * This code generates a 64bit identifier for a command submission.
> + * It works by adding the fence of the command submission to a automatically
'to an automatically'
> +/**
> + * radeon_seq_query - lockup fence by it's ID
'look up fence by its ID'
> + * @seq: sequence object
> + * @id: the generated ID
> + *
> + * Lockup the associated fence by it's ID.
'Look up the associated fence by its ID.'
> +/* The fourth and fives dword are a 64bit fence ID generated for this CS */
'fourth and fifth'
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-12-09 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 16:11 [PATCH 1/6] drm/radeon: take a fence reference in the sync code Christian König
2014-12-08 16:11 ` [PATCH 2/6] drm/radeon: add fence owners Christian König
2014-12-08 16:11 ` [PATCH 3/6] drm/radeon: add command submission IDs Christian König
2014-12-09 9:01 ` Michel Dänzer [this message]
2014-12-08 16:11 ` [PATCH 4/6] drm/radeon: add explicit command submission sync Christian König
2014-12-09 9:00 ` Michel Dänzer
2014-12-08 16:11 ` [PATCH 5/6] drm/radeon: optionally return an ID for the last PT update Christian König
2014-12-08 16:11 ` [PATCH 6/6] drm/radeon: add IOCTL to wait for a specific CS Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5486BA73.7020902@daenzer.net \
--to=michel@daenzer.net \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.